After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561562 - Single-includes for glib and GTK
Single-includes for glib and GTK
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks: 563413
 
 
Reported: 2008-11-19 18:17 UTC by Maxim Ermilov
Modified: 2008-11-20 18:44 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch for this bug (6.72 KB, patch)
2008-11-19 18:26 UTC, Maxim Ermilov 		committed Details | Review

Description Maxim Ermilov 2008-11-19 18:17:16 UTC 
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes
Comment 1 Maxim Ermilov 2008-11-19 18:26:57 UTC 
Created attachment 123056 [details] [review]
patch for this bug
Comment 2 Jens Granseuer 2008-11-19 18:41:09 UTC 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
-#include <gdk/gdkspawn.h>
+#include <gdk/gdk.h>

Hm... Spot anything wrong?

+#include <glib.h>

That should be glib/glib.h, shouldn't it?

Also, does the package still compile with the minimum version of glib and gtk+ given in configure.in after these changes, or do we need to bump the requirements?
Comment 3 Maxim Ermilov 2008-11-19 19:51:36 UTC 
(In reply to comment #2)
>  #include <gdk/gdk.h>
>  #include <gdk/gdkkeysyms.h>
> -#include <gdk/gdkspawn.h>
> +#include <gdk/gdk.h>
> 
> Hm... Spot anything wrong?
> 
> +#include <glib.h>
> 
> That should be glib/glib.h, shouldn't it?
No 
Error message:
"Only <glib.h> can be included directly."
> 
> Also, does the package still compile with the minimum version of glib and gtk+
> given in configure.in after these changes, or do we need to bump the
> requirements?
> 
Yes, It's compile with min version og glib and gtk+.
Comment 4 Jens Granseuer 2008-11-20 18:44:51 UTC 
Ok, committed minus the duplicate gdk.h inclusion. Thanks.

2008-11-20  Jens Granseuer  <...>

        Patch by: Maxim Ermilov <...>

        capplets/sound/mixer-support.[ch]:
        capplets/appearance/*.[ch]:
        capplets/common/*.[ch]:
        capplets/keybindings/egg*.[ch]:
        capplets/keyboard/gnome-keyboard-properties-a11y.h:
        shell/control-center.c:
        typing-break/*.[ch]:
        only include top-level headers for glib and GTK+ (bug #561562)