GNOME Bugzilla – Bug 561461
Update Icon Cache When Uninstalling Banshee
Last modified: 2009-01-21 20:08:48 UTC
When Banshee is installed/uninstalled, Banshee should update the icon cache to prevent issues when removing it after being compiled by source and then installed from a package. Otherwise, Banshee's icon will be missing from the GNOME menu and panel/desktop launchers. See the AppIcon GNOME Goal: http://live.gnome.org/GnomeGoals/AppIcon Other information:
I'm not sure I understand your issue. Could you describe the sequence of steps that leads to having missing icons in the GNOME menu ? After a quick look at the code, it seems the icon cache is updated during installation, but not during uninstallation. Maybe updating it also during uninstallation would solve your problem ?
(In reply to comment #1) > I'm not sure I understand your issue. Could you describe the sequence of steps > that leads to having missing icons in the GNOME menu ? Sure: 1. Compile and install Banshee from source. 2. Remove the installed Banshee. 3. Install Banshee from a package, such as a .deb. 4. Icons in the GNOME menu/launchers will be missing. The problem is that the icon entries become stale, with GNOME looking in /usr/local/share/icons/ despite the icons being removed already. > After a quick look at the code, it seems the icon cache is updated during > installation, but not during uninstallation. > Maybe updating it also during uninstallation would solve your problem ? Yeah, I think that would do the trick.
Created attachment 123165 [details] [review] Update the icon cache during "make uninstall" This patch modifies the icon-theme-installer script to remove the "x$INSTALL" = "xyes" condition around the code that updates the icon cache. The cache is then also updated on uninstall.
Just applied the patch and everything seems to be working as expected.
I just wanted to also confirm the bug (I built the 1.3 series from source but switched to PPA for 1.4, and now the icons are gone). I'm not sure how to apply a patch, but if someone tells me I'd like to test this one.
(In reply to comment #5) > I just wanted to also confirm the bug (I built the 1.3 series from source but > switched to PPA for 1.4, and now the icons are gone). > > I'm not sure how to apply a patch, but if someone tells me I'd like to test > this one. > I assume by your comment you already have the build dependencies and source for Banshee 1.4. Download the patch and save it into the banshee-1.4.1 folder. (Keep it's name as update_icon_cache_uninstall.patch.) Next, open a terminal and cd into the banshee-1.4.1 directory. Now run 'patch -p0 < update_icon_cache_uninstall.patch' (without the quotes). Finally, compile and install it as usual.
This patch looks correct to me, please commit after 1.4.2. Please use the 'usability' keyword only when you want input from the usability team.
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.