After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561451 - Cannot burn CDs with brasero
Cannot burn CDs with brasero
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
0.8.2
Other All
: Normal normal
: 0.8
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-11-19 00:42 UTC by Dries Harnie
Modified: 2009-01-17 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add --driver generic-mmc-raw using gconf (4.40 KB, patch)
2009-01-15 20:19 UTC, Luis Medinas
committed Details | Review

Description Dries Harnie 2008-11-19 00:42:28 UTC
Please describe the problem:
I cannot copy CDs with brasero because my dvd drive needs the generic-mmc-raw driver (as opposed to generic-mmc) from cdrdao apparently. I could not find a way to change this setting in the program.

Putting 
  write_driver: "generic-mmc-raw"
in ~/.cdrdao allowed me to write CDs.

Perhaps brasero should offer to try burning disks with the -raw driver or maybe even offer a preference to do this.

Steps to reproduce:
1. Try to copy a CD


Actual results:
Reading goes fine, but brasero throws an error and does not burn the CD.

Expected results:
The CD should be burned

Does this happen every time?
Yes.

Other information:
Editing ~/.cdrdao fixed the problem for me.
Comment 1 Philippe Rouquier 2008-12-13 21:04:54 UTC
Yes, I could add extra options for cdrdao plugin I guess. That won't be before 0.9.X and would not be accessible from the UI anyway but there would be a key in GConf.
Comment 2 Luis Medinas 2009-01-15 20:19:26 UTC
Created attachment 126533 [details] [review]
Add --driver generic-mmc-raw using gconf

This patch adds the --driver generic-mmc-raw option using gconf.

The flag is disabled by default you need to set to TRUE on gconf to use it.

Philipp it's ok to commit ?
Comment 3 Luis Medinas 2009-01-15 20:21:34 UTC
Dries Harnie, can you please test the patch if it works for you ?
Comment 4 Dries Harnie 2009-01-15 22:46:11 UTC
I tested your patch and it made brasero segfault when copying/burning.

I tracked the issue to a missing call to g_type_class_add_private:

--- brasero/src/plugins/cdrdao/burn-cdrdao.c.orig	2009-01-15 23:38:28.000000000 +0100
+++ brasero/src/plugins/cdrdao/burn-cdrdao.c	2009-01-15 23:38:35.000000000 +0100
@@ -541,6 +541,7 @@
 brasero_cdrdao_class_init (BraseroCdrdaoClass *klass)
 {
 	GObjectClass *object_class = G_OBJECT_CLASS (klass);
+	g_type_class_add_private(klass, sizeof(BraseroCdrdaoPrivate));
 	BraseroProcessClass *process_class = BRASERO_PROCESS_CLASS (klass);
 
 	parent_class = g_type_class_peek_parent(klass);

Once I fixed that, i tried flipping the raw_flag to on, and it worked!

Thank you!
Comment 5 Philippe Rouquier 2009-01-16 17:47:26 UTC
Luis, that looks good. Once you fix the above issue (it has the right fix indeed), please commit it.
Just one note, it still has the same spelling mistake "wheater" ;).
Comment 6 Philippe Rouquier 2009-01-17 13:08:50 UTC
Since we're in a bit of a hurry for next release, I committed the patch instead of Luis.