After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561150 - mxflat theme's button images are not installed when make install
mxflat theme's button images are not installed when make install
Status: RESOLVED FIXED
Product: Sawfish
Classification: Deprecated
Component: General
pre-1.3.x
Other All
: Normal normal
: 1.5.x
Assigned To: sawfish-maint
sawfish-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-17 05:51 UTC by Wang Diancheng
Modified: 2009-08-16 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Wang Diancheng 2008-11-17 05:51:09 UTC 
Please describe the problem:
sawfish svn version, mxflat theme's button images are not installed when make install. Because these images store in seperate directories, install program does not install directories.

I think we need modify the file "Makefile.in" in themes directory to fix this bug.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Michal Jaegermann 2008-11-17 16:28:07 UTC 
As it was posted a while ago on sawfish-list@gnome.org the following change:

--- sawfish-1.3.4/themes/Makefile.in.mkthm      2008-10-08 21:50:23.000000000 -0600
+++ sawfish-1.3.4/themes/Makefile.in    2008-11-02 18:46:50.000000000 -0700
@@ -47,10 +47,10 @@ all :
 install : all installdirs
        for d in $(THEMES); do \
          rm -rf $(DESTDIR)$(themedir)/$$d; \
-         mkdir $(DESTDIR)$(themedir)/$$d; \
          for f in $(srcdir)/$$d/*; do \
            if [ $$f != $(srcdir)/$$d/CVS ]; then \
-             $(INSTALL_DATA) $$f $(DESTDIR)$(themedir)/$$d; \
+             ( cd $(srcdir) && tar czf $$d.tar.gz $$d/* ) ; \
+             $(INSTALL_DATA) $$d.tar.gz $(DESTDIR)$(themedir)/$$d.tar.gz; \
            fi \
          done \
        done

installs all themes as compressed archives and avoids the issue no matter what an internal structure of a given theme.  There are no problems with sawfish handling that format. Additionally this saves quite a bit of a disk space. :-)
Comment 2 Christopher Roy Bratusek 2008-11-17 21:01:39 UTC 
Possible Solution. I'm sure for this to get in 1.3.5.
Comment 3 Christopher Roy Bratusek 2009-07-11 09:04:49 UTC 
fixed.