After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560977 - Cleaning up GTK Includes in vte
Cleaning up GTK Includes in vte
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-15 23:05 UTC by Maxim Ermilov
Modified: 2008-11-18 14:24 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Patch for this bug (403 bytes, patch)
2008-11-16 03:49 UTC, Maxim Ermilov 		none Details | Review

Description Maxim Ermilov 2008-11-15 23:05:25 UTC 
I'm working on implementing http://live.gnome.org/GnomeGoals/CleanupGTKIncludes

If it's not a good idea, or not currently on the agenda, please let me know.
Otherwise I'll be working on this for now.
Comment 1 Maxim Ermilov 2008-11-16 03:49:47 UTC 
Created attachment 122765 [details] [review]
Patch for this bug
Comment 2 Behdad Esfahbod 2008-11-18 13:31:43 UTC 
That's an overkill.  If the only part of glib that gnome-pty-helper uses is g_alloca (which seems to be the case), I'd rather get rid of that dependency.  g-p-h is a suid app, so the less it includes the better for sure.
Comment 3 Christian Persch 2008-11-18 14:11:28 UTC 
I removed glib use from g-p-h. Only needed g_alloca->alloca, and gboolean->int, FALSE->0, TRUE->1.
Comment 4 Behdad Esfahbod 2008-11-18 14:14:34 UTC 
I was thinking that alloca may not be portable.  But we can wait and see :).
Comment 5 Christian Persch 2008-11-18 14:24:50 UTC 
Right. If it turns out to be aproblem, we could use AC_FUNC_ALLOCA + stuff (see autoconf manual), or just use an ordinary malloc and free before returns :)