After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560882 - Column headers are center aligned instead of left aligned
Column headers are center aligned instead of left aligned
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-11-15 01:59 UTC by Andreas Nilsson
Modified: 2008-11-18 15:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
screenshot of the current behaviour (6.50 KB, image/png)
2008-11-15 02:00 UTC, Andreas Nilsson 		  Details
Proposed patch (963 bytes, patch)
2008-11-15 18:23 UTC, Matthew Barnes 		committed Details | Review
Screenshot of the new behavior (9.27 KB, image/png)
2008-11-15 18:24 UTC, Matthew Barnes 		  Details

Description Andreas Nilsson 2008-11-15 01:59:40 UTC 
The headers in the messages column are center aligned, while most other places in GNOME (gtk-filechooser, nautilus, banshee, the plugin window in evolution) showing lists aligns them to the left. If the text in the list itself and the header are aligned it creates less visual lines for the eye to keep track of.
Comment 1 Andreas Nilsson 2008-11-15 02:00:22 UTC 
Created attachment 122709 [details]
screenshot of the current behaviour
Comment 2 Matthew Barnes 2008-11-15 14:47:46 UTC 
Note to whomever tackles this: the message list is an ETable widget, not a GtkTreeView.
Comment 3 Matthew Barnes 2008-11-15 18:23:54 UTC 
Created attachment 122741 [details] [review]
Proposed patch

Had to fiddle with the column padding, which makes the icon columns a tad wider.  But I don't see that being a problem.  Note that this affects all ETables in Evolution, not just the message list.
Comment 4 Matthew Barnes 2008-11-15 18:24:54 UTC 
Created attachment 122742 [details]
Screenshot of the new behavior

I like it, but CC'ing Srini for a second opinion.
Comment 5 Andreas Nilsson 2008-11-16 15:26:52 UTC 
woohoo! looks great!
Thanks for the quick fix!
Comment 6 Srinivasa Ragavan 2008-11-17 03:19:51 UTC 
Matt, looks nice. It seems to look better than usual :-)

Not sure, if this is a UI freeze, but I would love to see in stable. May be check with the release team.
Comment 7 Matthew Barnes 2008-11-17 20:17:48 UTC 
Committed to trunk (revision 36792).

Waiting to hear back from the release team before committing to stable.  Closing, regardless.
Comment 8 Matthew Barnes 2008-11-18 15:43:22 UTC 
Committed to gnome-2-24 with release team approval (revision 36794).