After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560821 - Keyboard Preferences are not taken into use when a keyboard is plugged in
Keyboard Preferences are not taken into use when a keyboard is plugged in
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-14 16:37 UTC by Andrej Czapszys
Modified: 2009-04-29 17:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Patch from bug 549267 redone for the keyboard (2.21 KB, patch)
2008-11-14 16:39 UTC, Andrej Czapszys 		needs-work Details | Review
Correct Patch from bug 549267 redone for the keyboard (2.90 KB, patch)
2008-11-14 19:52 UTC, Andrej Czapszys 		needs-work Details | Review

Description Andrej Czapszys 2008-11-14 16:37:29 UTC 
I have a USB keyboard plugged into my monitor.  Whenever I turn off my monitor, I effectively unplug my keyboard.
After turning the monitor back on, my settings are set back to defaults (ex: no compose key).  This seems to be the same sort of issue as bug 549267, but with the keyboard.
Comment 1 Andrej Czapszys 2008-11-14 16:39:31 UTC 
Created attachment 122670 [details] [review]
Patch from bug 549267 redone for the keyboard
Comment 2 Andrej Czapszys 2008-11-14 16:54:21 UTC 
Something is not right with that patch.  Plugging and unplugging still does not work reliably.
Comment 3 Jens Granseuer 2008-11-14 18:52:33 UTC 
+                apply_settings ((GsdKeyboardManager *) data);

Erm, yes, maybe because that is very very wrong? ;-)

Also note that the patch from bug 549267 still has issues (bug 560618).
Comment 4 Andrej Czapszys 2008-11-14 19:52:00 UTC 
Created attachment 122685 [details] [review]
Correct Patch from bug 549267 redone for the keyboard

I uploaded the wrong file last time.  That wouldn't have compiled.
This one still doesn't work, but I built it and it's running.
Comment 5 Sergey V. Udaltsov 2008-11-14 21:11:48 UTC 
I would not like to fix it on that level. I am planning to fix it in libxklavier.
Comment 6 Sergey V. Udaltsov 2008-11-14 21:16:42 UTC 
I mean - libxklavier would intercept device presence event, provide a hook (in normal gobject/signal style), then in g-s-d the hook would reinitialize the keyboard.
Comment 7 Bastien Nocera 2009-04-29 16:13:45 UTC 
The patch actually looks like the right thing to do for me, but it's missing handling of the DeviceAdded events.
Comment 8 Sergey V. Udaltsov 2009-04-29 17:31:27 UTC 
It is done in libxklavier and gnome 2.26 ATM, could you please check if it still an issue? Make sure libxklavier is built with xinput support (that's not the case with ubuntu, so far)