GNOME Bugzilla – Bug 560641
rtp mp4 payloader doesn't flush the last frame upon EOS
Last modified: 2009-01-23 08:42:27 UTC
Please describe the problem: The rtpmp4vpay pushes the frames one by one, such that the current frame causes the previous frame to be "released". Thus, the "final" frame is never sent out. Steps to reproduce: 1. Create a pipeline consisting of a source streaming a finite-length file. 2. "Record" the resulting stream by any means (wireshark, dumping, etc.) 3. Compare input frame count and output frame count Actual results: Last frame is not pushed from the payloader Expected results: EOS event is handled by flushing remainder frames Does this happen every time? Yes Other information: Related to bug #434824
Created attachment 122575 [details] [review] Proposed fix Solves the issue and AFAIK doesn't break anything else
Patch by: Yotam <sh dot yotam at gmail dot com> * gst/rtp/gstrtpmp4vpay.c: (gst_rtp_mp4v_pay_event): Flush the remaining frames on EOS. Fixes #560641.