After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560399 - Unnecessary CRC checksum for binary registry cache
Unnecessary CRC checksum for binary registry cache
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-11-11 20:07 UTC by Simon Holm Thøgersen
Modified: 2008-11-12 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Simon Holm Thøgersen 2008-11-11 20:07:16 UTC
Please describe the problem:
Following the discussion on gstreamer-devel "On the plugin cache" the CRC checksum in the binary registry cache is not necessary and should thus be removed.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Sebastian Dröge (slomo) 2008-11-12 10:38:19 UTC
2008-11-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	* gst/gstregistrybinary.c: (gst_registry_binary_write_chunk),
	(gst_registry_binary_initialize_magic),
	(gst_registry_binary_write_cache),
	(gst_registry_binary_check_magic):
	* gst/gstregistrybinary.h:
	Don't write and check a CRC for the binary registry file. It's
	guaranteed that the registry is completely written (it's first written
	to a temporary file and then moved) and if the registry was corrupted
	by some hardware failure we would have bigger problems.

	This saves some milliseconds for reading/writing the registry.
	Fixes bug #560399.