After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560385 - Better HTML output for reports
Better HTML output for reports
Status: RESOLVED FIXED
Product: hamster-applet
Classification: Deprecated
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: hamster-applet-maint
hamster-applet-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-11 18:04 UTC by Giorgos Logiotatidis
Modified: 2008-11-13 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to provide nicer HTML output (5.57 KB, patch)
2008-11-11 18:07 UTC, Giorgos Logiotatidis
none Details | Review
Patch to provide nicer HTML output (5.53 KB, patch)
2008-11-12 22:44 UTC, Giorgos Logiotatidis
committed Details | Review

Description Giorgos Logiotatidis 2008-11-11 18:04:19 UTC
Provide a better HTML output for reports. Use some more CSS!
Comment 1 Giorgos Logiotatidis 2008-11-11 18:07:00 UTC
Created attachment 122438 [details] [review]
Patch to provide nicer HTML output
Comment 2 Toms Bauģis 2008-11-11 19:23:39 UTC
Great job George! 

* It might be better to use less color. See Gnome HIG on Color [1]
* Activity column is now flexible and when browser is full-screen it makes 
  somewhat harder for the eye to scan the row. How about using padding, or 
  fixed-width table instead?


[1] http://library.gnome.org/devel/hig-book/stable/design-color.html.en
Comment 3 Giorgos Logiotatidis 2008-11-12 22:43:40 UTC
OK I made same changes regarding colors and table size. Looks nice now. I also changed the default font to "Sans" which I think it's a better option and provides same font quality to the proprietary fonts I used before.

Besides colors and fonts, I noticed that on the first table we don't print "Unsorted" from unsorted activities but on the summary table we do. I think that we you stay one way or the other, so a made a small change on line 156, so we don't print "Unsorted" at all.
Comment 4 Giorgos Logiotatidis 2008-11-12 22:44:44 UTC
Created attachment 122532 [details] [review]
Patch to provide nicer HTML output
Comment 5 Toms Bauģis 2008-11-13 10:59:51 UTC
Thanks Giorgos, this will do for now - commited in TRUNK!

I reverted the unsorted behaviour though - reason behind it is, that, it would get too noisy if every activity with unsorted category would have "unsorted" in it, but it makes perfect sense to summarize these activities as "unsorted" in totals.

Also added you to copyrights.

Thanks again - keep rocking!