GNOME Bugzilla – Bug 560349
Use "warning" icon instead GTK_STOCK_MISSING_IMAGE for missing files source
Last modified: 2011-07-26 19:46:24 UTC
As per summary, the GTK_STOCK_MISSING_IMAGE is not the proper icon for the scope of missing file source. That icon should be showed only when on *image* is not available (for example, web pages linking to wrong JPEG file), not for missing music files. A better icon could be the one used for warning alerts. Patch attached.
Created attachment 122421 [details] [review] Proposed patch Changed to use "image-missing" named icon from fd.o Icon Naming Spec. GTK_STOCK_DIALOG_WARNING could be used too.
Of course the previous comment sould be "changed to use dialog-warning" Moreover, I forgot to check. rb-import-errors-source.c is yet using GTK_STOCK_DIALOG_ERROR, so * previous patch is wrong and should use GTK_STOCK_DIALOG_WARNING * previous patch is right and we should update rb-import-errors-source.c to use "dialog-error" too. Let me know what's preferred and I'll commit ASAP.
I'm not sure dialog-warning is the right thing to use. It seems a bit strong - you can ignore missing files with no ill effects at all. Still, probably better than the current icon. I guess rb-import-errors-source should be changed too. Maybe we should replace the current 50 or so uses of GTK_STOCK_x with icon naming spec names?
You're talking about changing(In reply to comment #3) > I'm not sure dialog-warning is the right thing to use. It seems a bit strong - > you can ignore missing files with no ill effects at all. Still, probably > better than the current icon. > > I guess rb-import-errors-source should be changed too. Maybe we should replace > the current 50 or so uses of GTK_STOCK_x with icon naming spec names? > You're talking about changing the instances of GTK_STOCK_x with their lower-case 'defined' counterparts? http://library.gnome.org/devel/gtk/2.14/gtk-Stock-Items.html#GTK-STOCK-SAVE:CAPS so GTK_STOCK_CLOSE would become "gtk-save"? If that's the case, I can see a well-crafted sed script in my future. :)
> I'm not sure dialog-warning is the right thing to use. > It seems a bit strong - you can ignore missing files with no ill > effects at all. Still, probably better than the current icon. Yes, I proposed warning icon just to avoid the need of a new custom named icon in Rhythmbox. Rhythmbox is yet using error icon, so warning seems suitable: if you know you removed/renamed some files, it's not a tragedy to see the icon, instead if you ignore that some files was removed or renamed, warning icon could help to call attention. > I guess rb-import-errors-source should be changed too. Maybe we should > replace the current 50 or so uses of GTK_STOCK_x with icon naming spec names? This was the fd.o Icon Naming Spec intention ;) Overcome toolkit retaled stock icon definitions. IMHO could be a good idea replace GTK_STOCK_X with named icon from spec. But ask on gnome-devel list or gtk-devel list before. Genereally, it seems to me that developers tends to use stock when the icon is provided by both gtk stock and naming spec. But I don't know if this is just a bad habit or a silent standard. Honestly I was planning to open a bug against gtk+ asking to swith to fd.o Naming Spec for GTK+ 3 and to provide custom gtk+ icons (for example GTK_STOCK_LANDSCAPE_ORIENTATION) as custom icon theme under $prefix/share/gtk/icons/hicolor/ not as builtin pixbuf (see gtkbuiltincache.h) > so GTK_STOCK_CLOSE would become "gtk-save"? "gtk-close", maybe :) IMHO should become directly "window-close" (see http://people.freedesktop.org/~jimmac/icons/).
Landed in release 6047 2008-11-14 Luca Ferretti <elle.uca@libero.it> * sources/rb-missing-files-source.c: (rb_missing_files_source_init): use named icon "dialog-warning" instead improper GTK_STOCK_MISSING_IMAGE. Fixes bug #560349 * sources/rb-import-errors-source.c: (rb_import_errors_source_init): use named icon "dialog-error" instead GTK_STOCK_DIALOG_ERROR to match previous change Closing bug.