After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560147 - GtkBuilder docs should say what GErrors they throw
GtkBuilder docs should say what GErrors they throw
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkBuilder
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: GtkBuilder maintainers
GtkBuilder maintainers
Depends on: 615000
Blocks: 548022
 
 
Reported: 2008-11-10 14:27 UTC by Murray Cumming
Modified: 2010-04-06 20:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add documentation about error domain (3.41 KB, patch)
2010-04-06 19:05 UTC, Tristan Van Berkom
none Details | Review
Clean documentation only patch (2.67 KB, patch)
2010-04-06 19:59 UTC, Tristan Van Berkom
none Details | Review

Description Murray Cumming 2008-11-10 14:27:05 UTC
The documentation for the gtk_builder_* functions should say what classes of GError they show. For instance,
gtk_builder_add_from_file()
throws both GtkBuilderError and GFileError but that is not mentioned:
http://library.gnome.org/devel/gtk/unstable/GtkBuilder.html#gtk-builder-add-from-file

I think they might throw GMarkupError GErrors too, but I'm not sure.
Comment 1 Murray Cumming 2009-02-21 13:38:22 UTC
This is really very important.
Comment 2 Tristan Van Berkom 2010-04-06 19:05:10 UTC
Created attachment 158072 [details] [review]
Add documentation about error domain

This patch also catches a possible error when trying to
deserialize an object that is not a pixbuf while calling
gtk_builder_value_from_string_type().
Comment 3 Murray Cumming 2010-04-06 19:33:27 UTC
(In reply to comment #2)
> This patch also catches a possible error when trying to
> deserialize an object that is not a pixbuf while calling
> gtk_builder_value_from_string_type().

That should be a separate patch then, in a separate bug report.
Comment 4 Tristan Van Berkom 2010-04-06 19:57:41 UTC
Moving patch to correct gtk_builder_value_from_string_type() to bug 615000.

Marked to depend on that as the documentation lies...
Comment 5 Tristan Van Berkom 2010-04-06 19:59:42 UTC
Created attachment 158076 [details] [review]
Clean documentation only patch
Comment 6 Tristan Van Berkom 2010-04-06 20:31:42 UTC
Applied docs patch, closing.