GNOME Bugzilla – Bug 560017
Various Slideshow Mode Improvements
Last modified: 2018-07-01 09:02:52 UTC
I made 3 patches addressing different fullscreen issues. 1. In the current version in slideshow mode on my system photos are only shown with a maximum resolution of 1024x1024. It's because my video card can't handle larger textures. So even if the photos have a resolution of 2288x1712 they're not shown in full screen resolution which is 1400x1050 on my system. The small_textures patch addresses this issue. Maybe that's a problem that applies to other people too. 2. This fixes the white-to-image-transition-bug already discussed in http://bugzilla.gnome.org/show_bug.cgi?id=361031 but never really resolved. @Stephane: I know you asked me not to remove the accessors, but really in this case I see no purpose in using them. They do such complex stuff that you could never use them intuitivly without knowing what exactly they do. And even if you do know it's confusing to use them. My suggestion is to remove them. I'd really appreciate if you could commit this change into drunk, because this bug now made it through several versions although I think it's very annoying. 3. This might be a personal taste, but I think the transitions in slideshow mode are a little bit too slow. As screensaver they may fulfill there task, but for a photo presentation they're tiring. So I changed the value from 3 seconds to 1 second. But that's just the default value it can now be changed in gconf-editor to a desired value. I just think that one second is a better default value. (So far I don't know how to add the value to gconf-editor by "make install". Can anybody point me to the place?) In addition I changed the flip transition. It now accelerates the rotation in a way which I think is more attractive. I'd be glad to get comments on that.
Created attachment 122261 [details] [review] fixes slideshow mode when screen resolution is higher than supported texture size of video card
Created attachment 122262 [details] [review] fixes the white-to-image transition bug in slideshow mode
Created attachment 122263 [details] [review] more appropriate default value for transition in slideshow mode and improved flip transition
Comment on attachment 122261 [details] [review] fixes slideshow mode when screen resolution is higher than supported texture size of video card Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment on attachment 122262 [details] [review] fixes the white-to-image transition bug in slideshow mode Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment on attachment 122263 [details] [review] more appropriate default value for transition in slideshow mode and improved flip transition Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
f-spot is not under active development anymore, has not seen code changes for five years, and saw its last tarball release in the year 2010. Its codebase has been archived: https://gitlab.gnome.org/Archive/f-spot/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.