GNOME Bugzilla – Bug 559710
Do not close Event/Task/Memo editor on save
Last modified: 2013-04-10 11:36:41 UTC
Steps to reproduce: * Start a new task. * Type something in the Summary line and Description. * Click the "Save" toolbar button, or go File -> Save. What happens: * The task closes. What should happen. * The task should not close. I did not ask it to close, I asked it to save. Happens in: Evolution 2.22.3.1 and 2.24.1 Other information:
Steps to reproduce: * Start a new mail. * Type something in the Summary line and Body. * Click the "Send" toolbar button, or go File -> Send. What happens: * The composer window closes. So...? :-) Sorry, WONTFIX.
Please, please, please: reconsider closing this. It is not an intuitive interface. It does not do what the user asked it to do. If you send a mail, the user _expects_ it to send, and go away. But nobody expects saving something to close the window. Let's suppose you were using a word processor, and went File -> Save. And the word processor saved your work, and then the window closed. Just vanished, without warning or explanation. Would you think that was a good interface for a word processor? Really? And if so, then why doesn't OpenOffice (or any office suite) do this? Or any text editor, for that matter? To the user, a task editor is similar to a simple word processor or a text editor, and they expect a similar type of behaviour from it. It may be that you are only making very short task notes, in which case "close on save" may seem like a time-saver for the way you use it; but some of my tasks run for about 8 or 10 printed pages of text, and as soon as you get to non-trivial amounts of information in a task, then you want to save your work regularly. This is particularly so given that Evolution crashes (e.g. it crashed 3 times on me yesterday), and one of those times I lost about half a page of updates to a Task. And the reason I lost those updates was because I did not save, and the reason I did not save was because I knew it would close the window, and I did not want it to do that because I was not finished with the task. So "close on save" to me is not a good interface. In case this was some personal misconception of mine, I just asked my non-techie girlfriend about this, and described the behaviour, in purely factual terms (enter information in Task, click save, window disappears), without trying to give any value judgement about it, and then had the following conversation: ----------------------- Me - Q: do you think this is a good interface or a bad interface? GF - A: Bad. Me - Q: Why? GF - A: Because when the window disappears like that, I assume there must have been an error or that something went wrong. Me - Q: But if it saved your work correctly, and then closed? GF - A: But just because you saved, doesn't mean you wanted it to close. Suppose Microsoft Word did that! Me - Q: Okay, but when you send an email, the window disappears. Isn't that the same thing? GF - A: No, it's completely different. Send means "go away", and send only applies to mail programs. Save is used everywhere, and it has a defined meaning: Save my work, now, and then let me keep working. ----------------------- ... and indeed, after the above conversation (the bit about thinking it was an error or crash), I can confirm that when the window closing first happened to me, I assumed that something had gone wrong. I opened up the just-closed task, and was relieved to see that my changes had been saved. So the user's natural initial thought process is: "Went to go save -> window vanishes -> I didn't ask it to vanish -> there must have been an error or a crash -> is my work safe?" I don't think that's a good thought process for the user to be having whilst using Evolution. Please, I sincerely request that this User Interface be reconsidered.
Well, you're the very first one complaining about this in those 5 years I've been reading Evolution bugs. :) Reopening until a second person also closes as WONTFIX...
To be fair, I think only a small percentage of users ever touch the Tasks and Memos components in Evolution. And those that do just get used to its quirks. The button is meant to mean "I'm done editing, commit my changes". Perhaps Apply would be a better label than Save?
Maybe "save and close"? I'm loathe to compare with Outlook, but it's my only point-of-reference for this type of functionality, so here goes. It has: A toolbar with a save to disk icon and the label "save and close", which will save + close, and no "close" button; It also has a File pulldown menu with "save" (and an associated ctrl-s shortcut) which will save, but not close. Overall it works fine, and everything does what you'd expect it to do. So in terms of resolving this, I'd suggest perhaps a short-term fix of changing the button label to "Save and close" (so that the label matches the behavior), and then a later change to make File->Save and Ctrl-s do a save but not a close.
Sounds reasonable to me. The toolbar isn't really the right place for a Close button anyway. I'd support just dropping it. This will have to wait until 2.27 since we're under a UI freeze now. Tagging it for my kill-bonobo branch.
*** Bug 632482 has been marked as a duplicate of this bug. ***
Created attachment 213855 [details] [review] evo patch for evolution; "Save and Close" and "Save" buttons on toolbar and menu, Ctrl+S being left on "Save". I created a composite icon for the "Save and Close", but I wasn't sure which would be better order, whether close being large and save being small or vice versa, and with my current icon theme it looked horrible with large save and small close icon, thus I made it large close and small save icon. The toolbar itself has plenty of space, thus I do not see any problem with having both icons there. The Save and Close is first, thus no change for those using mouse, only except of the icon. Also, the editor is shared between all calendar/task/memo views, thus this is in all of them now.
Created commit a8fb183 in evo master (3.5.2+)
(In reply to comment #10) > Created commit a8fb183 in evo master (3.5.2+) Hrm, it's commit d2de841
Woohoo, thank you, that's fantastic! Evo 3.6 is sounding like an _awesome_ release :-)