After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559671 - Cleanups for -DG_DISABLE_DEPRECATED
Cleanups for -DG_DISABLE_DEPRECATED
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
devel
Other Linux
: Low enhancement
: 0.98
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks: 560423
 
 
Reported: 2008-11-06 22:23 UTC by Kjartan Maraas
Modified: 2010-08-03 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (9.50 KB, patch)
2008-11-06 22:23 UTC, Kjartan Maraas 		committed Details | Review

Description Kjartan Maraas 2008-11-06 22:23:02 UTC 
Attaching a patch
Comment 1 Kjartan Maraas 2008-11-06 22:23:18 UTC 
Created attachment 122158 [details] [review]
patch
Comment 2 Hans Breuer 2008-12-09 20:30:06 UTC 
Thanks, applied:

2008-12-09  Hans Breuer  <hans@breuer.org>

	* lib/diasvgrenderer.c lib/persistence.c lib/prop_basic.c : reduced
	use of long time deprecated functions ( Kjartan Maraas, bug #559671)
Comment 3 Javier Jardón (IRC: jjardon) 2009-06-20 15:25:54 UTC 
This bus is still not fixed.

See http://www.gnome.org/~fpeters/299.html for deprecated Glib symbols already in use.
Comment 4 André Klapper 2009-06-20 15:47:29 UTC 
"Still not fixed" is misleading - probably those symbols have been deprecated after this bug had been closed as FIXED. :-)

Curerntly offending symbols are:
g_basename, g_dirname, g_strcasecmp, g_strncasecmp
Comment 5 Hans Breuer 2009-06-20 16:02:10 UTC 
If you cite that page, please also follow the link given there to
http://bugzilla.gnome.org/show_bug.cgi?id=575016

This had a patch in nothing to do with huge deprecation work. And the reopening was simply wrong.
Comment 6 André Klapper 2009-06-20 16:16:03 UTC 
Hans: Reopening was not wrong. The bug you link against is about GTK+.
This is about Glib.
Comment 7 Hans Breuer 2009-06-20 16:49:58 UTC 
Reopening still was wrong, for the reason *you* gave. The patch is applied and released quite some time ago.
Comment 8 André Klapper 2009-06-20 17:17:37 UTC 
Yeah, that's why I now set the patch status to "committed" and reopen.
And everything is fine and correct.
Comment 9 Hans Breuer 2009-06-20 17:26:21 UTC 
Of course you are right, I should have resolved as invalid.
Comment 10 Rodolphe Marques 2010-07-15 17:42:36 UTC 
Just compiled it with make CFLAGS+="-DG_DISABLE_DEPRECATED" and it compiled just fine, although there are some deprecated symbols. maybe the functions that call the deprecated symbols are unused.