After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559584 - does not build on GNOME 2.25
does not build on GNOME 2.25
Status: RESOLVED FIXED
Product: quick-lounge-applet
Classification: Deprecated
Component: general
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2008-11-06 12:34 UTC by Götz Waschk
Modified: 2009-01-30 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for 1st solution. (51.90 KB, patch)
2009-01-30 12:10 UTC, Michal Pryc 		none Details | Review

Description Götz Waschk 2008-11-06 12:34:20 UTC 
In gnome-desktop 2.25.1, GnomeDItemEdit was removed, so quick-lounge-applet doesn't build anymore:
gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -DPREFIX=\"/usr\" -DSYSCONFDIR=\"/etc\" -DDATADIR=\"/usr/share\" -DLIBDIR=\"/usr/lib\" -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DGLADEDIR=\""/usr/share/quick-lounge-applet/glade"\" -DGMENU_I_KNOW_THIS_IS_UNSTABLE  -pthread -DORBIT2=1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libxml2 -I/usr/include/gail-1.0 -I/usr/include/gnome-vfs-module-2.0 -I/usr/include/gnome-desktop-2.0 -I/usr/include/startup-notification-1.0 -I/usr/include/libglade-2.0 -I/usr/include/panel-2.0 -I/usr/include/gnome-menus      -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -MT dlg-properties.o -MD -MP -MF .deps/dlg-properties.Tpo -c -o dlg-properties.o dlg-properties.c
dlg-properties.c:31:41: Fehler: libgnomeui/gnome-ditem-edit.h: Datei oder Verzeichnis nicht gefunden
make: *** [dlg-properties.o] Fehler 1
Comment 1 Andrew Starr-Bochicchio 2008-12-19 15:32:10 UTC 
Confirmed here as well.

GnomeDItemEdit has been deprecated in libgnome-desktop. This causes quick-lounge-applet to to fail to build.

dlg-properties.c calls <libgnomeui/gnome-ditem-edit.h>
Comment 2 Andrew Starr-Bochicchio 2008-12-19 15:50:21 UTC 
quick-box.c and quick-lounge.c also include <libgnomeui/gnome-ditem-edit.h>
Comment 3 Matt Keenan (IRC:MattMan) 2009-01-29 16:33:16 UTC 
Any idea if this is going to be addressed in the 2.25/26 timeframe ?
as it is quick-lounge applet is unusable.

If we want to continue using quick-lounge, then we cannot bump gnome-panel
and gnome-desktop :(
Comment 4 Vincent Untz 2009-01-29 17:20:00 UTC 
I don't know the quick lounge code at all. I see two solutions:

 + copy panel-ditem-editor.[ch] from gnome-panel
 + directly call gnome-desktop-item-edit
Comment 5 Paolo Bacchilega 2009-01-30 09:37:15 UTC 
I'll fix it in the next days, sorry for the delay.
Comment 6 Michal Pryc 2009-01-30 12:10:12 UTC 
Created attachment 127533 [details] [review]
Patch for 1st solution.

> I don't know the quick lounge code at all. I see two solutions:
> 
>  + copy panel-ditem-editor.[ch] from gnome-panel

This is patch for 1st solution.
Comment 7 Paolo Bacchilega 2009-01-30 16:14:43 UTC 
patch applied to trunk, thanks.