After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559167 - Preload gconf dirs when feasible
Preload gconf dirs when feasible
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-03 19:09 UTC by Behdad Esfahbod
Modified: 2008-11-03 21:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (16.54 KB, patch)
2008-11-03 19:11 UTC, Behdad Esfahbod 		committed Details | Review

Description Behdad Esfahbod 2008-11-03 19:09:18 UTC 
The change in the gnome-settings-daemon/ has the most measurable effect, but the plugin changes are correct too.  In each case I studied the access pattern and chose the correct preloading level.
Comment 1 Behdad Esfahbod 2008-11-03 19:11:54 UTC 
Created attachment 121900 [details] [review]
the patch
Comment 2 Jens Granseuer 2008-11-03 21:16:50 UTC 
Usual identation issues. Rest is fine.
Comment 3 Behdad Esfahbod 2008-11-03 21:36:44 UTC 
Committed after indentation fix.

2008-11-03  Behdad Esfahbod  <behdad@gnome.org>

        * gnome-settings-daemon/gnome-settings-manager.c (_load_file),
        (gnome_settings_manager_start), (gnome_settings_manager_stop):
        * gnome-settings-daemon/gnome-settings-plugin-info.c
        (gnome_settings_plugin_info_set_enabled_key_name):
        * plugins/a11y-keyboard/gsd-a11y-keyboard-manager.c
        (register_config_callback):
        * plugins/keybindings/gsd-keybindings-manager.c
        (register_config_callback), (gsd_keybindings_manager_start):
        * plugins/keyboard/gsd-keyboard-manager.c
        (gsd_keyboard_manager_start):
        * plugins/keyboard/gsd-keyboard-xkb.c (register_config_callback):
        * plugins/mouse/gsd-mouse-manager.c (register_config_callback):
        * plugins/typing-break/gsd-typing-break-manager.c
        (gsd_typing_break_manager_start):
        * plugins/xrandr/gsd-xrandr-manager.c (gsd_xrandr_manager_start):
        * plugins/xsettings/gsd-xsettings-manager.c
        (register_config_callback), (gnome_xsettings_manager_start):
        Preload gconf dirs when feasible (bug #559167)