After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559164 - Don't trap errors around grab_key
Don't trap errors around grab_key
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2008-11-03 19:05 UTC by Behdad Esfahbod
Modified: 2008-11-03 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (8.85 KB, patch)
2008-11-03 19:10 UTC, Behdad Esfahbod 		committed Details | Review

Description Behdad Esfahbod 2008-11-03 19:05:27 UTC 
Such that we can do a single gdk_flush for multiple keys.  The only downside
is that we cannot write out in the warning which key is being accessed by
another app.  Not that we really care.
Comment 1 Behdad Esfahbod 2008-11-03 19:10:38 UTC 
Created attachment 121897 [details] [review]
The patch
Comment 2 Jens Granseuer 2008-11-03 20:31:19 UTC 
Broken indentation in lots of places. Otherwise looks good.
Comment 3 Behdad Esfahbod 2008-11-03 21:29:06 UTC 
Committed after indentation fix.

2008-11-03  Behdad Esfahbod  <behdad@gnome.org>

        * plugins/common/gsd-keygrab.c (setup_modifiers), (grab_key_real),
        (grab_key_unsafe):
        * plugins/common/gsd-keygrab.h:
        * plugins/keybindings/gsd-keybindings-manager.c
        (binding_register_keys):
        * plugins/media-keys/gsd-media-keys-manager.c (update_kbd_cb),
        (init_kbd):
        Don't trap errors around grab_key (bug #559164)

        Such that we can do a single gdk_flush for multiple keys.
        The only downside is that we cannot write out in the warning
        which key is being accessed by another app.  Not that we really
        care.