After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558674 - registry: don't copy strings when reading the cache
registry: don't copy strings when reading the cache
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-31 15:08 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2018-11-03 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
latest patch, needs update in 3 hunks (13.61 KB, patch)
2008-10-31 16:46 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review
avoid copying strings (15.67 KB, patch)
2008-11-03 08:40 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review
avoid copying strings (15.58 KB, patch)
2008-11-03 08:58 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		rejected Details | Review
avoid copying strings (15.56 KB, patch)
2008-11-03 12:58 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		rejected Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-31 15:08:22 UTC 
There are some enhancement idea about the gstreamer registry described in Bug #359653#c35 and Bug #359653#c36. This is an attempt to do it.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-31 16:46:22 UTC 
Created attachment 121735 [details] [review]
latest patch, needs update in 3 hunks
Comment 2 Sebastian Dröge (slomo) 2008-10-31 18:20:57 UTC 
Looks good but you're breaking ABI in GstPluginFeature and GstRegistry by adding stuff but not making the padding smaller ;)
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2008-11-03 08:40:01 UTC 
Created attachment 121850 [details] [review]
avoid copying strings

now applies cleanly and has abi stability fixed.
needs more commenting and testing
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2008-11-03 08:58:03 UTC 
Created attachment 121852 [details] [review]
avoid copying strings

one less instance var. did several meassurements, but it fluctuates too much. speed is in same range as before
Comment 5 Wim Taymans 2008-11-03 10:10:19 UTC 
We should use the GstObject flags for the plugins and features instead of adding new fields and methods.
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2008-11-03 12:58:24 UTC 
Created attachment 121863 [details] [review]
avoid copying strings

Last patch missed some things. Need to readd mmap usage and make sure it keep working.

Wim, I was wondering if GST_OBJECT_FLAG_CONST is to generic. Should we name it GST_OBJECT_FLAG_CONST_STRINGS an define that (all?) gchar * fields in that object are not to be free'ed on destruction.
Comment 7 Edward Hervey 2013-07-18 05:08:26 UTC 
Tim, didn't you have a more generic proposal for making the registry based on GVariant (and only loading data on-demand) ?
Comment 8 Tim-Philipp Müller 2013-07-18 10:51:09 UTC 
Yes, but punting it to the next cycle. I'd like to keep this open for now.
Comment 9 Sebastian Dröge (slomo) 2013-07-24 08:12:57 UTC 
Comment on attachment 121863 [details] [review]
avoid copying strings

Rejecting because the plan is to just go with GVariant now
Comment 10 GStreamer system administrator 2018-11-03 12:13:02 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/9.