After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558636 - pam module: keyring should be stopped if it was started when changing password
pam module: keyring should be stopped if it was started when changing password
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-10-31 06:52 UTC by Vincent Untz
Modified: 2008-12-11 20:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for this (1.37 KB, patch)
2008-11-07 18:15 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2008-10-31 06:52:42 UTC 
Looking at pam_chauthtok_update(), there's this comment:

	/* 
	 * We always start the daemon here, and don't respect the auto_start
	 * argument. Because if the password is being changed, then making 
	 * the 'login' keyring match it is a priority. 
	 */

Totally makes sense. However, if we actually autostarted the daemon (ie, it was not running), then we should also stop it and I don't see this in the code (or am I missing something?)
Comment 1 Vincent Untz 2008-11-07 18:15:27 UTC 
Created attachment 122195 [details] [review]
Patch for this

Note that I didn't test the patch yet.
Comment 2 Vincent Untz 2008-11-09 01:10:57 UTC 
Tested the patch a bit and it seems to work fine.
Comment 3 Stef Walter 2008-12-11 20:44:25 UTC 
Cool. Right on. Committed.