After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558427 - rtpmpapay/depay are too wide
rtpmpapay/depay are too wide
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-29 18:10 UTC by Olivier Crête
Modified: 2009-01-23 08:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Olivier Crête 2008-10-29 18:10:00 UTC 
The caps on rtpmpapay and rtpmpadepay are "audio/mpeg", from our IRC discussion, I guess they should be restricted to mpegversion=1. Even though RFC 3551, Section 4.5.13 says that it could be version 1 or 2..  In that case, we need some way to differentiate it from AAC.
Comment 1 Sebastian Dröge (slomo) 2008-10-30 04:38:46 UTC 
That mpegversion, is it the version of mpeg 1 audio, i.e. the "MPEG Audio version id" from http://www.mp3-tech.org/programmer/frame_header.html ?

In that case you can use the mpegaudioversion caps field but it will be added by lame/mp3parse only with latest releases.
Comment 2 Wim Taymans 2008-10-30 10:31:26 UTC 
        * gst/rtp/gstrtpmpadepay.c: (gst_rtp_mpa_depay_setcaps):
        * gst/rtp/gstrtpmpapay.c:
        Narrow down the caps of the mpeg audio pay/depayloaders to only accept
        mpeg version 1. Fixes #558427.