GNOME Bugzilla – Bug 558253
build fails under Solaris
Last modified: 2008-11-05 20:44:29 UTC
Build of 1.14.10 under Solaris 10 fails with gsf-output-stdio.c: In function `rename_wrapper': gsf-output-stdio.c:81: error: too few arguments to function `statfs' gsf-output-stdio.c:82: error: structure has no member named `f_type' statfs is defined as int statfs(const char *, struct statfs *, int, int); in /usr/include/sys/statfs.h. configure seems to test for the presence of statfs, but not if it is usable (in this way).
Ok, that's bad but not quite a blocker for most of our users. It would be helpful if you could come up with a patch that just disables the code in question if stat is not of the two-arg form we expect. I don't want a direct test for Solaris as other systems might have similar issues.
The configure script of gnome-vfs defines such a test. The result is used in modules/file-method.c.
Created attachment 121671 [details] [review] Tentative patch Please test this patch.
Would you at least look at the code in gnome-vfs? There is more than Linux and the rest of the world. Nearly every OS does statfs differently. Maybe there is another method to test for a FUSE fs??
I looked. It's different and even more complete. It does not matter. The point is that I am unable to test changes like this. Someone else will have to come up with a patch that does something interesting. Then I can look that over and verify that it does no damage on Linux. (I don't even know if FUSE exists for Solaris. http://opensolaris.org/os/project/fuse/ suggests that one day it might.)
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report. We're open for further patches, if needed.