After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558241 - automagically crop one set of backgrounds to required aspect ratios [patch]
automagically crop one set of backgrounds to required aspect ratios [patch]
Status: RESOLVED OBSOLETE
Product: gnome-desktop
Classification: Core
Component: Background
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 558143 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-28 14:09 UTC by Máirín Duffy
Modified: 2018-09-21 16:27 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch from Charlie Brej to enable background cropping (4.17 KB, patch)
2008-10-28 14:16 UTC, Máirín Duffy
none Details | Review

Description Máirín Duffy 2008-10-28 14:09:34 UTC
See https://www.redhat.com/archives/fedora-art-list/2008-October/msg00319.html for more details.

"Current solar background's consume 33Mb. This a bit on the heavy side, especially on the Live CD which is over its image limit. Currently there are 4 different images (morning, noon, evening, night) sent out in 4 different sizes (4:3, 16:10, 5:4 and 8:3 for dual screen). What we could do is to send out just one 3200:1200 image and patch up gnome-desktop background handling to support cropping to the right aspect. This would allow us to ship just one 3200x1200 size of each time of day image."
Comment 1 Máirín Duffy 2008-10-28 14:16:21 UTC
Created attachment 121519 [details] [review]
patch from Charlie Brej to enable background cropping
Comment 2 Máirín Duffy 2008-10-28 14:17:27 UTC
I'm not sure if Charlie's patch does resizing or if it just does cropping, but I think resizing is important too (e.g., resize down to as close without losing anything from within the desired aspect ratio / dimensions, then crop off any excess left over from the resizing)
Comment 3 Baptiste Mille-Mathias 2008-10-28 14:32:04 UTC
Comment on attachment 121519 [details] [review]
patch from Charlie Brej to enable background cropping

just setting the attachment is a patch
Comment 4 Charlie Brej 2008-10-28 15:47:07 UTC
Is duplicate of #558143
Comment 5 Vincent Untz 2008-12-01 16:09:43 UTC
*** Bug 558143 has been marked as a duplicate of this bug. ***
Comment 6 Vincent Untz 2008-12-01 16:11:03 UTC
(In reply to comment #2)
> I'm not sure if Charlie's patch does resizing or if it just does cropping, but
> I think resizing is important too (e.g., resize down to as close without losing
> anything from within the desired aspect ratio / dimensions, then crop off any
> excess left over from the resizing)

Looking at the patch, I think it does no resizing. However, resizing will result in some blurry stuff, won't it?
Comment 7 Vincent Untz 2008-12-01 17:55:11 UTC
See also bug 524542 for another proposal. Would be nice to evaluate this approach.
Comment 8 GNOME Infrastructure Team 2018-09-21 16:27:28 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-desktop/issues/21.