After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558121 - Podcast files are not deleted
Podcast files are not deleted
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Podcasting
git master
Other All
: Normal major
: 1.x
Assigned To: Mike Urbanski
Mike Urbanski
: 572641 573902 580677 583732 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-27 16:16 UTC by Ivan Zlatev
Modified: 2009-05-24 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set the file attributes to normal before deleting file (678 bytes, patch)
2009-04-13 17:39 UTC, Bertrand Lorentz
committed Details | Review

Description Ivan Zlatev 2008-10-27 16:16:00 UTC
Please describe the problem:
E.g. clicking on "Remove Downloaded Files" does not result the podcast file to be deleted. Might be related to bug 558120.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Benjamín Valero Espinosa 2008-12-11 22:46:08 UTC
The explanation given in the related bug #558120 seems reasonable, but then the podcasts cannot be deleted as they has no write permissions. Difficult situation, it seems...
Comment 2 Nick 2009-02-26 21:30:44 UTC
I'm also encountering this for all subscribed podcasts. Despite being listed in banshee as not-downloaded after the delete command, the files are definitely still present in ~/Music/Podcasts. They even get sucked into the general music library due to being under ~/Music.

I'm seeing this in current SVN.
Comment 3 valentin.sawadski 2009-03-01 09:05:35 UTC
*** Bug 572641 has been marked as a duplicate of this bug. ***
Comment 4 Bertrand Lorentz 2009-04-13 15:55:38 UTC
I can confirm Benjamín's findings from bug #558120 :
In FeedEnclosure.DeleteFile, File.Delete fails, cetainly because the file is read-only.

[Warn  17:46:52.946] Caught an exception - Access to the path "/home/lorentz/Music/Library/Podcasts/Down and Out in the Magic Kingdom/PB-MagicKingdom-07.mp3" is denied. (in `mscorlib')
  at System.IO.File.Delete (System.String path) [0x000ba] in /var/tmp/portage/dev-lang/mono-2.2-r5/work/mono-2.2/mcs/class/corlib/System.IO/File.cs:187 
  at Migo.Syndication.FeedEnclosure.DeleteFile () [0x0002d] in /home/lorentz/Projets/banshee/src/Libraries/Migo/Migo.Syndication/FeedEnclosure.cs:141 

Maybe we need to set it to RW before deleting ?
Comment 5 Bertrand Lorentz 2009-04-13 17:39:12 UTC
Created attachment 132602 [details] [review]
Set the file attributes to normal before deleting file

This patch sets the file attributes to "normal" before deleting a podcast file. Changing the attribute allows R/W access to the file.
Please test for any regressions or bad behavior.

FYI, this probably surfaced when the following bug was fixed in mono :
https://bugzilla.novell.com/show_bug.cgi?id=378229
Comment 6 Gabriel Burt 2009-04-15 22:19:17 UTC
Thanks Bertrand.
Comment 7 Bertrand Lorentz 2009-04-26 09:53:59 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 8 Alexander Kojevnikov 2009-04-29 02:21:16 UTC
*** Bug 573902 has been marked as a duplicate of this bug. ***
Comment 9 Alexander Kojevnikov 2009-04-29 02:23:15 UTC
*** Bug 580677 has been marked as a duplicate of this bug. ***
Comment 10 Bertrand Lorentz 2009-05-24 20:08:16 UTC
*** Bug 583732 has been marked as a duplicate of this bug. ***