After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557990 - Remove prefix from enums values
Remove prefix from enums values
Status: RESOLVED FIXED
Product: goocanvasmm
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2008-10-26 18:46 UTC by Louis-Francis Ratté-Boulianne
Modified: 2011-01-16 23:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove CANVAS_* from enums (1.95 KB, patch)
2008-11-07 17:32 UTC, José Alburquerque 		none Details | Review

Description Louis-Francis Ratté-Boulianne 2008-10-26 18:46:43 UTC 
As of now, values in enumerations have all the prefix CANVAS_. I think the prefix should be removed because it is redundant. Also, the C++ bindings of GTK+ (gtkmm, gdkmm, cairomm) don't add any prefix to the enum values (for example : Gdk::SHIFT_MASK,  Gtk::PACK_START...)
Comment 1 Murray Cumming 2008-10-26 21:17:49 UTC 
Yes, Goocanvas::CANVAS_* is not nice.
Comment 2 José Alburquerque 2008-11-07 17:32:56 UTC 
Created attachment 122189 [details] [review]
Patch to remove CANVAS_* from enums

I'm not sure if fixing this would break any other software so I think that's why this has not been fixed, but just in case, I think this patch would fix this.  It can be applied whenever it is convenient.
Comment 3 Murray Cumming 2008-11-07 17:34:34 UTC 
Great. Please apply.

We are not really API or ABI stable yet, so it's OK.
Comment 4 José Alburquerque 2008-11-07 20:21:38 UTC 
2008-11-07  José Alburquerque  <jaalburqu@svn.gnome.org>

	* goocanvas/src/enums.hg:
	* goocanvas/src/itemmodel.hg:
	* goocanvas/src/path.hg: Modify enums so that CANVAS_* is removed.
	Bug #557990 (Louis-Francis Ratté-Boulianne)