After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557866 - Translation context needed for "Queue" button
Translation context needed for "Queue" button
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other All
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on: 557880
Blocks:
 
 
Reported: 2008-10-25 14:28 UTC by Wouter Bolsterlee (uws)
Modified: 2009-01-21 21:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Initial patch (1015 bytes, patch)
2008-10-25 17:04 UTC, Wouter Bolsterlee (uws) 		committed Details | Review

Description Wouter Bolsterlee (uws) 2008-10-25 14:28:17 UTC 
The label of the "Queue" button needs translation context, i.e. use the C# equivalent of Q_(), since Queue can be both a verb and a noun (and is in fact used as both throughout Banshee, e.g. Play Queue).

The exact string is:

  #: ../src/Clients/Muinshee/Muinshee/BaseDialog.cs:83
  msgid "Queue"

...which comes from this line of code:

  Button queue_button = new ImageButton (Catalog.GetString ("Queue"), "stock_timer");
Comment 1 Wouter Bolsterlee (uws) 2008-10-25 14:31:23 UTC 
Oh, and while you're at it, add keyboard accelerators for both the "Queue" and the "Play" buttons. Thanks.
Comment 2 Wouter Bolsterlee (uws) 2008-10-25 17:04:27 UTC 
Created attachment 121353 [details] [review]
Initial patch

A better solution would perhaps be to use "Enqueue" instead of "Queue" as the button label. The attached patch:

- changes "Queue" to "En_queue"
- changes "Play" to "_Play"

For some reason the mnemonics for these buttons don't work, but I fail to see why. The one on the close button works fine...
Comment 3 Wouter Bolsterlee (uws) 2008-10-25 17:18:19 UTC 
Okay, opened bug 557880 for the mnemonic issue. This patch is fine otherwise.
Comment 4 Bertrand Lorentz 2008-11-13 21:53:10 UTC 
Looks fine, thanks !
Comment 5 Gabriel Burt 2008-12-29 20:57:35 UTC 
Please commit, Wouter.
Comment 6 Wouter Bolsterlee (uws) 2008-12-29 21:13:39 UTC 
Same here as in #557880: please do so for me—I don't have any development environment on my machine currently.
Comment 7 Gabriel Burt 2008-12-29 21:21:37 UTC 
Whoops, forgot about the string freeze, we'll wait to commit for a bit.
Comment 8 Bertrand Lorentz 2009-01-21 21:54:09 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.