After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557740 - vinagre-2.24.1 treats avahi as mandatory dependency
vinagre-2.24.1 treats avahi as mandatory dependency
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
2.24.x
Other All
: Normal enhancement
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2008-10-24 12:28 UTC by Bonekracker
Modified: 2008-11-12 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (make avahi optional) (49.28 KB, patch)
2008-10-24 12:37 UTC, Bonekracker
committed Details | Review

Description Bonekracker 2008-10-24 12:28:46 UTC
Vinagre's functionality does not depend on avahi.  Avahi should be optional.

There should be a compile-time option to toggle the avahi dependency.
Comment 1 Jonh Wendell 2008-10-24 12:36:57 UTC
Hi. Avahi is an external dependency of GNOME, as you can see at http://live.gnome.org/TwoPointTwentythree/ExternalDependencies.

So, every GNOME application can depend on it.
Comment 2 Bonekracker 2008-10-24 12:37:56 UTC
Created attachment 121265 [details] [review]
Proposed patch (make avahi optional)

Sven E.'s patch (Make avahi optional)

This patch adds a --enable-avahi configure switch and does conditional
compilation.

Re: https://bugs.gentoo.org/show_bug.cgi?id=243004
Comment 3 Bonekracker 2008-10-24 13:05:30 UTC
(In reply to comment #1)
> Hi. Avahi is an external dependency of GNOME, as you can see at
> http://live.gnome.org/TwoPointTwentythree/ExternalDependencies.
> 
> So, every GNOME application can depend on it.
> 

I see.  That's too bad.  This seems like feature bloat to me.

It would be nice if use of Avahi were an option left to distribution packagers.  Avahi has been optional for a long time.  Nothing that's mandatory in Gnome relies upon mDNS/dns-sd capability.

There are other forms of name resolution, especially in managed environments.

In my opinion, forcing this dependency on users makes Gnome less flexible and limits the range of purposes for which it is useful.
Comment 4 Gilles Dartiguelongue 2008-10-24 23:38:23 UTC
Hi guys,

let me reformulate Bonekracker's bug report. This is a feature request to make avahi optional if this is possible. I do not deny the interest of avahi in general, I'm a big fan of it but there is situations in which it is just extra unneeded weight.

In the case that was exposed to us on IRC we had people having real worl use with DNS names and perfectly known resources that had no advantage in using avahi and as such don't want to enable it nor to have it on their system.

Please reconsider this patch even if it needs some work to ease the maintenance.
Comment 5 Mart Raudsepp 2008-10-25 21:35:46 UTC
Reopening for consideration then.
In Gentoo Linux the user could choose if he/she wants avahi support globally or for a specific package, and the distribution doesn't make the choice for him/her but lets them do it themselves, so there is additional value to this, while binary distributions probably would always enable it (which should be the default if the relevant configure option isn't passed)
Comment 6 Jonh Wendell 2008-11-11 17:13:44 UTC
OK, guys, you won! Just committed your patch [a bit modified].

This will be in for 2.25 (trunk) tough.
Comment 7 Bonekracker 2008-11-12 00:13:19 UTC
Thank you, John.