After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557591 - Auto-filter messed up after undo of column delete
Auto-filter messed up after undo of column delete
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Sheet Objects
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-10-23 11:41 UTC by Henry Law
Modified: 2008-10-24 02:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Henry Law 2008-10-23 11:41:56 UTC
step to reproduce:
1. add a auto filter(i.e. A1:D3)
2. delete columns in auto filter(i.e. C:D)
3. undo
4. remove auto filter

expected result:
filter removed without any problem.

actual result:
combo box in used to be deleted columns remains.
and gnumeric segfault when trying to play with them.

additional finding:
after step 3. seems that auto filter's range
is not restored correctly. step 4 can only
be done by selecting columns which has not
been deleted in step 2(i.e. A or B).
Comment 1 Morten Welinder 2008-10-23 14:04:30 UTC
Updating title to reflect that since step 4 above does not remove
all the combos, something is wrong with the filter after the undo.
Comment 2 Morten Welinder 2008-10-23 15:59:49 UTC
There are a lot of problems here.

1. After an undo, the old sheet object (the combo box thingy) comes back.
   The is because sheet_objects_clear carefully arranges for exactly that.
   (For regular objects that is a good thing.)

2. If a partial filter is deleted, the undo inserts columns and with new
   fields.  Thus there will be two combos, :-/

3. If the entire filter is deleted, the GnmFilter is deleted.  Nothing will
   bring it back, and the combo from 1 will still point at the deleted one.
Comment 3 Morten Welinder 2008-10-23 17:19:10 UTC
(1) is fixed and things do not crash anymore.  --> Lowering severity.

Undo still does not work right if the right-most column (or more) is
removed.
Comment 4 Morten Welinder 2008-10-24 02:47:31 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.