After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557316 - GtkLinkButton should consider user-defined tooltip
GtkLinkButton should consider user-defined tooltip
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-10-21 20:55 UTC by Jonh Wendell
Modified: 2008-10-30 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only override the tooltip if not previously set (607 bytes, patch)
2008-10-29 17:00 UTC, Christian Dywan 		committed Details | Review

Description Jonh Wendell 2008-10-21 20:55:55 UTC 
Since 2.14, GtkLinkButton shows its own tooltip, which is the URI. It just ignores any tooltip defined by the user.

Ideally, it should check for :tooltip-text/:tooltip-markup and show them if they exist. If not, it does what it's doing right now: use the URI as tooltip.
Comment 1 Christian Dywan 2008-10-29 17:00:44 UTC 
Created attachment 121591 [details] [review]
Only override the tooltip if not previously set

This patch does exactly as proposed, it checks if tooltip text or markup is set on the widget before attempting to override the tooltip text and only does so if neither is set.
Comment 2 Emmanuele Bassi (:ebassi) 2008-10-29 17:31:24 UTC 
thanks Christian, you beat me to it. :-)

since the current 2.14 approach causes a regression (tooltips set in 2.12 are discarded in 2.14) let's commit it to trunk and gtk-2-14.
Comment 3 Matthias Clasen 2008-10-30 04:37:02 UTC 
Looks ok to me.
Comment 4 Christian Dywan 2008-10-30 09:26:19 UTC 
2008-10-30  Christian Dywan  <christian@imendio.com>

	Bug 557316 – GtkLinkButton should consider user-defined tooltip

	* gtk/gtklinkbutton.c (gtk_link_button_query_tooltip_cb):
	Only override the tooltip if not previously set

Committed to trunk and gtk-2-14.