After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557313 - Album Artist not used correctly if some songs have Artist == Album Artist
Album Artist not used correctly if some songs have Artist == Album Artist
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.3.3
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 560862 560907 566357 566922 569963 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-21 20:52 UTC by Wouter Bolsterlee (uws)
Modified: 2009-06-05 07:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Create only one database entry for compilation albums (1.98 KB, patch)
2008-12-05 00:55 UTC, John Millikin
committed Details | Review

Description Wouter Bolsterlee (uws) 2008-10-21 20:52:36 UTC
Consider an album with these songs:

- Artist 1 - Track 1
- Artist 2 - Track 2
- Artist 3 - Track 3
- Artist 4 - Track 4

All songs have the Album Artist set to "Artist 2" (the same string as one of the individual songs of the album contains in its Artist field).

Expected result: album shows up as 1 album

Actual result: album shows up as 2 albums:
- One with Track 1, Track 3, and Track 4
- One with Track 2
...i.e. the song with Album Artist == Artist is treated as a stand-alone album, while it's part of the compilation album.
Comment 1 Wouter Bolsterlee (uws) 2008-10-21 20:54:33 UTC
Note that only Track 2 does *not* have the "album artist" checkbox selected in the track properties. If I manually enable it, the albums appear as they should. Perhaps the importer drops Album Artist if it's the same as Artist?
Comment 2 Gabriel Burt 2008-10-21 21:10:57 UTC
Is this with 1.3.2 or trunk?
Comment 3 Andrew Conkling 2008-10-23 19:30:18 UTC
And were they imported with Banshee?

Which album is this? I'm wondering if I could reproduce it with a similar one that I have.
Comment 4 Wouter Bolsterlee (uws) 2008-11-03 12:27:48 UTC
This is still an issue with 1.3.3. If I manually fix it in Banshee the tracks are merged into a single album.


Andrew,

For MP3: this is with any album where TPE1 is not the same for each track. Just set TPE2 to the same value for all tracks, reusing one of the TPE1 names. Try with mid3v2 (from the python-mutagen debian package) using "mid3v2 --TPE2=Foo"

For Ogg/Vorbis: set ALBUMARTIST to one of the ARTISTs that occur on a multi-ARTIST disk.

To summarize: if I use "Various Artists" (or something else that is not used in a regular track artist field) for the TPE2/ALBUMARTIST tags everything works fine, but if I set it to one of the values also used for TPE1/ARTIST for at least one of the tracks, it does not.
Comment 5 Wouter Bolsterlee (uws) 2008-11-15 14:22:33 UTC
*** Bug 560862 has been marked as a duplicate of this bug. ***
Comment 6 Wouter Bolsterlee (uws) 2008-11-15 14:22:58 UTC
Bug #560862 has a patch for this issue.
Comment 7 Bertrand Lorentz 2008-11-15 14:44:40 UTC
*** Bug 560907 has been marked as a duplicate of this bug. ***
Comment 8 John Millikin 2008-12-05 00:55:19 UTC
Created attachment 123970 [details] [review]
Create only one database entry for compilation albums

(reposting my patch from bug #560862, so it won't get lost / will be easier to find)

If a compilation album is imported, it will have multiple entries created; one with IsCompilation = 0, and the other = 1.

This patch modifies the `DatabaseAlbumInfo.FindOrCreate` method, so that if it
finds an existing album that differs only in the IsCompilation flag, it will
update the saved album.
Comment 9 Gabriel Burt 2008-12-29 20:36:19 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 10 Bertrand Lorentz 2009-01-02 21:29:01 UTC
*** Bug 566357 has been marked as a duplicate of this bug. ***
Comment 11 Bertrand Lorentz 2009-01-07 19:03:48 UTC
*** Bug 566922 has been marked as a duplicate of this bug. ***
Comment 12 Bertrand Lorentz 2009-02-18 17:54:21 UTC
*** Bug 569963 has been marked as a duplicate of this bug. ***
Comment 13 Michal Pěnka 2009-05-27 19:31:08 UTC
I ask for a reopening of this bug (maybe I should create new one?).

I still suffer from this while having all my songs served by DAAP.

I've got Mortal Kombat soundtrack (flac). I want to select the album in the list of albums and see all the songs (various artists) inside. I'm able to do this by using the search field - if I write there "mortal kombat" it lists all the songs and I'm able to order them not by clicking the track number (strange) but by clicking the album column.

Is fix possible? Or am I doing something wrong?
Comment 14 Michal Pěnka 2009-06-05 07:27:38 UTC
OK, I'm going to file new bug so that anybody can see it.