After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557070 - Add a macro to check for single header includes
Add a macro to check for single header includes
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
2.24.x
Other Linux
: Normal enhancement
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
: 539456 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-20 12:44 UTC by Cosimo Cecchi
Modified: 2009-08-08 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1001 bytes, patch)
2008-10-26 13:21 UTC, Christian Persch 		committed Details | Review

Description Cosimo Cecchi 2008-10-20 12:44:20 UTC 
Currently we have GNOME_MAINTAINER_MODE_DEFINES which takes care of enabling all the CFLAGS for deprecated functions for the libraries the stack.
Why not add a similar macro that enables -DG_DISABLE_SINGLE_INCLUDES and friends? (or even add that to GNOME_MAINTAINER_MODE_DEFINES)
Comment 1 Christian Persch 2008-10-20 12:51:03 UTC 
I wanted to file the very same bug :)

I think just adding them to the defines in GNOME_MAINTAINER_MODE_DEFINES should be ok. I think we should get the opinion of d-d-l first, though.
Comment 2 Cosimo Cecchi 2008-10-20 13:36:05 UTC 
I just sent a mail to d-d-l to gather feedback.
Comment 3 Christian Persch 2008-10-26 13:21:44 UTC 
Created attachment 121378 [details] [review]
patch

No protests on ddl, I guess we can go ahead with this :)
Comment 4 Christian Persch 2008-10-26 13:37:52 UTC 
I guess we should make sure the gnome-suites-2.26 modules build with this, and file patches where they don't?
Comment 5 Cosimo Cecchi 2008-10-27 14:26:00 UTC 
Yes, I think this is a good plan. I will try to build all the modules tonight or tomorrow, as now I'm on battery ;) If you want to beat me at it, feel free, but anyway let's try to keep here a list of modules/bugs affected by this so that we don't duplicate the work.
Comment 6 Vincent Untz 2008-11-06 12:21:06 UTC 
Cosimo: any news? :-)
Comment 7 Cosimo Cecchi 2008-11-07 16:07:12 UTC 
Sorry for the delay.
I am currently building all the modules, will post the results as soon as my slow PC finishes.
Comment 8 Cosimo Cecchi 2008-11-11 00:15:26 UTC 
So, I managed to build the modules, except Evolution and some python modules and the only modules which were affected were
- totem/totem-pl-parser
- at-spi (not directly, some other program compiled with the flags was linking to it)
- libepc (ditto)

I committed the trivial single includes fixes to all of them, so there shouldn't be any additional breakage with this patch, which we should commit.
Comment 9 Cosimo Cecchi 2008-11-11 00:17:09 UTC 
*** Bug 539456 has been marked as a duplicate of this bug. ***
Comment 10 Tobias Mueller 2009-04-04 16:44:24 UTC 
Hey Cosimo :)

Have you already committed the patch in attachment #121378 [details]? If so, could you please set the status accordingly?

Also, what is still needed to close this bug? ;-)

Cheers!
Comment 11 Cosimo Cecchi 2009-08-08 13:24:07 UTC 
Pushed an updated variation of this.
Closing as FIXED.
Comment 12 Vincent Untz 2009-08-08 16:05:06 UTC 
(In reply to comment #11)
> Pushed an updated variation of this.
> Closing as FIXED.

Can you push your commit? :-)
Comment 13 Vincent Untz 2009-08-08 16:05:48 UTC 
Argh, I was thinking of another bug. Sorry :-)