After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557027 - Exporting the attached gnumeric file as MS Excel (tm) 97/2000/XP gives segfault
Exporting the attached gnumeric file as MS Excel (tm) 97/2000/XP gives segfault
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
1.9.x
Other All
: Normal critical
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-10-20 04:45 UTC by Reggie Chan
Modified: 2008-11-11 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnumeric file causing segfault (2.20 KB, application/octet-stream)
2008-10-20 04:46 UTC, Reggie Chan
  Details
should fix the issue (4.67 KB, patch)
2008-10-20 07:04 UTC, Jean Bréfort
none Details | Review
new patch (5.48 KB, patch)
2008-10-31 10:47 UTC, Jean Bréfort
committed Details | Review

Description Reggie Chan 2008-10-20 04:45:02 UTC
it happens on 1.8.3 on linux and 1.9.1 on windows.

I'll attach the gnumeric file in the next comment.
Comment 1 Reggie Chan 2008-10-20 04:46:45 UTC
Created attachment 120902 [details]
gnumeric file causing segfault

Attaching the gnumeric file as per previous comment.
Comment 2 Jean Bréfort 2008-10-20 05:39:39 UTC


  • #6 ms_excel_chart_write
    at ms-chart.c line 5731

I'll have a look.
Comment 3 Jean Bréfort 2008-10-20 05:58:09 UTC
I understand what happens, but it seems there are several issues around there, so it might take some time to fix.
Comment 4 Jean Bréfort 2008-10-20 07:04:16 UTC
Created attachment 120906 [details] [review]
should fix the issue

It appears that there are other issues concerning contour plots in trunk :-(
Anyway this bug seems fixed with this patch.
Comment 5 Jody Goldberg 2008-10-20 08:46:38 UTC
Comment on attachment 120906 [details] [review]
should fix the issue

Interacting directly with the klass is more than a bit nasty.   The followup safety checks seem prudent, but are also worrisome.  If they trigger is the resulting xls valid ?
Comment 6 Jean Bréfort 2008-10-20 11:07:45 UTC
I'll add a function to avoid the direct access to the klass. The resulting xls needs some testing. If it was not valid, we might just drop the plot (which would be easier anyway).
Comment 7 Jean Bréfort 2008-10-20 11:36:20 UTC
The resulting xls crashes gnumeric, but not calc.
Comment 8 Morten Welinder 2008-10-20 13:31:37 UTC
Import crash filed separately as bug 557077.
Comment 9 Jean Bréfort 2008-10-31 10:47:23 UTC
Created attachment 121722 [details] [review]
new patch

This one does not access the klass. Resulting xls files can be opened in excel with no apparent issue, and in gnumeric, with some commited fixes to goffice.
Comment 10 Morten Welinder 2008-11-02 21:45:05 UTC
Do we really need to call G_OBJECT_TYPE_NAME?  Is there a GO_IS_A_ macro
that could be used instead?
Comment 11 Jean Bréfort 2008-11-03 07:41:42 UTC
There is a macro, but it is defined in the plot_surface plugin and can't be used elsewhere unless we install the plugin headers.
Comment 12 Jean Bréfort 2008-11-11 13:45:35 UTC
Patch commited (both branches).