After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556955 - [videocrop] fails to renegotiate
[videocrop] fails to renegotiate
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-19 14:56 UTC by Thijs Vermeir
Modified: 2009-02-19 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videocrop.diff (1.47 KB, patch)
2008-10-19 15:01 UTC, Thijs Vermeir 		committed Details | Review

Description Thijs Vermeir 2008-10-19 14:56:26 UTC 
When you change one of the crop properties (top/bottom/left/right) after the pipeline has gone to pauze/playing, the videocrop element is not renegotiating the caps and with the next pad_alloc comming from upstream, basetransform is still using the same method for allocing the buffer and this can cause a crash of the pipeline. (if going from proxy-alloc to non-proxy alloc function)
Comment 1 Thijs Vermeir 2008-10-19 15:01:15 UTC 
Created attachment 120865 [details] [review]
videocrop.diff

force recheck of buffer_alloc method
Comment 2 Thijs Vermeir 2009-01-25 21:31:11 UTC 
This was fixed some time ago with this commit:

commit 6ab4698b95bed4ca4032b791d84f26fd2e11224a
Author: Wim Taymans
Date:   Tue Nov 25 16:06:22 2008 +0000

    gst/videocrop/gstvideocrop.*: Fix renegotiation when changing properties using the new basetransform features. Fixes ...
    
    Original commit message from CVS:
    * gst/videocrop/gstvideocrop.c: (gst_video_crop_init),
    (gst_video_crop_transform), (gst_video_crop_transform_caps),
    (gst_video_crop_set_caps), (gst_video_crop_set_property):
    * gst/videocrop/gstvideocrop.h:
    Fix renegotiation when changing properties using the new basetransform
    features. Fixes #561502.
    * tests/icles/Makefile.am:
    * tests/icles/videocrop2-test.c: (make_pipeline), (main):
    Add crazy interactive test unit for dynamically changing properties.