After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556804 - Zoom drop down doesn't update
Zoom drop down doesn't update
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.6.1
Other Windows
: Normal normal
: 2.6
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-10-18 05:32 UTC by Robert Navas
Modified: 2008-10-22 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Zoom drop down doesn't update above 100% (689.88 KB, image/png)
2008-10-18 05:45 UTC, Robert Navas
  Details
Zoom drop down doesn't update above 100% XCF file (930.57 KB, application/octet-stream)
2008-10-18 05:51 UTC, Robert Navas
  Details
fix-scaled-emission-2008-10-18.patch (1.34 KB, patch)
2008-10-18 07:47 UTC, Martin Nordholts
committed Details | Review

Description Robert Navas 2008-10-18 05:32:29 UTC
Hi GIMP developers,
I noticed that when I try to resize my canvas using the "+" and "-" keys, the zoom drop down updates showing the current magnification but only when the magnification is less than 100%, when you resize higher than 100% the drop down doesn't update.

Also when you press the "1" key to resize the canvas to 100% it fails when the current magnification is higher than 100%.

My PC specs are as follows:
Windows XP SP3
NVIDIA GeForce4 MX 4000
1GB RAM
Pentium 4 2.8GHz

Thanks
Comment 1 Robert Navas 2008-10-18 05:45:08 UTC
Created attachment 120822 [details]
Zoom drop down doesn't update above 100%
Comment 2 Robert Navas 2008-10-18 05:51:52 UTC
Created attachment 120823 [details]
Zoom drop down doesn't update above 100% XCF file

compressed with 7-zip
http://www.7-zip.org/
Comment 3 Martin Nordholts 2008-10-18 07:47:36 UTC
Created attachment 120826 [details] [review]
fix-scaled-emission-2008-10-18.patch

Hi and thanks for the bug report!

This bug occurs when one have 'Resize window on zoom' enabled and one zooms in, but the image window is too big to be further enlarged. The cause is bogus emissions of the GimpDisplayShell::"scaled" signal.

The attached patch seems to fix this but I am going to do more extensive testing on it before I commit it.
Comment 4 Martin Nordholts 2008-10-22 19:04:54 UTC
Seems to work, and should work, just fine. Commited to trunk rev 27366 and gimp-2-6 rev 27367:

2008-10-22  Martin Nordholts  <martinn@svn.gnome.org>

	Bug 556804 – Zoom drop down doesn't update

	* app/display/gimpdisplayshell-scale.c
	* app/display/gimpdisplayshell-callbacks.c: Fix calls to
	gimp_display_shell_scaled() when Resize window on zoom is enabled.