After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556793 - Sound Juicer sucks cos its uses libgnomeui
Sound Juicer sucks cos its uses libgnomeui
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other Linux
: Immediate blocker
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
: 565347 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-17 23:56 UTC by iain
Modified: 2014-03-24 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch to make sound-juicer GOOD! (3.42 KB, patch)
2008-10-17 23:57 UTC, iain 		none Details | Review
Much much better patch (3.49 KB, patch)
2008-10-18 13:08 UTC, iain 		none Details | Review
Bump the gtk requirement to 2.14 (3.49 KB, patch)
2008-10-19 22:32 UTC, iain 		none Details | Review
Remove libgnome dependency (4.18 KB, patch)
2008-12-22 15:39 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description iain 2008-10-17 23:56:07 UTC 
While watching the new south park episode it dawned on me that sound-juicer sucks a lot. Unlike the new south park episode.

Attached is a patch to make it much better
Suck it!
Comment 1 iain 2008-10-17 23:57:34 UTC 
Created attachment 120813 [details] [review]
A patch to make sound-juicer GOOD!

BEST PATCH EVA!!!!
Comment 2 iain 2008-10-18 13:08:25 UTC 
Created attachment 120828 [details] [review]
Much much better patch

Forgot to add the Gtk options. Je un moronique!
Comment 3 Ross Burton 2008-10-19 18:07:39 UTC 
gtk_show_uri is part of GTK+ 2.14.
Comment 4 iain 2008-10-19 22:32:31 UTC 
Created attachment 120891 [details] [review]
Bump the gtk requirement to 2.14

Sigh, never satisfied
Comment 5 Ross Burton 2008-12-22 15:13:14 UTC 
*** Bug 565347 has been marked as a duplicate of this bug. ***
Comment 6 Emilio Pozuelo Monfort 2008-12-22 15:39:27 UTC 
Created attachment 125144 [details] [review]
Remove libgnome dependency

The attached patch also removes libgnome from src/sj-prefs.c and src/sj-extracting.c

The gtk+ dependency is bumped to 2.13.1, since gtk_show_uri was added in that release.
Comment 7 Ross Burton 2008-12-22 22:20:48 UTC 
Committed a merge of the latest two patches to trunk, thanks.
Comment 8 André Klapper 2009-01-10 15:48:34 UTC 
Updated http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp accordingly.