GNOME Bugzilla – Bug 556787
Patch to implement SafeUri entirely in managed code
Last modified: 2018-07-10 23:02:15 UTC
I've developed a patch to implement the marshaled functions in SafeUri in C# instead of as a call out to GLib.
Created attachment 120806 [details] A new version of SafeUri.cs
Created attachment 120807 [details] [review] Patch for SafeUri
The functions implemented are almost exactly based on the corresponding functions in GLib.
Thanks for the patch. Please follow the coding style guideline in the HACKING file : space before method parenthesis, method names... Some unit tests would also be nice, to make sure there are no regressions.
I'm cleaning up the code so it fits the coding style guidelines and beginning to work on unit tests. I'm trying to think of Uri cases for testing. Here is what I have: (these cases will be tested in both directions and "round-tripped") file:///some/path/song.ext -> /some/path/song.ext (these two need to be tested on Win32) file://C:\some\path\song.ext -> C:\some\path\song.ext file://C:/some/path/song.ext -> C:\some\path\song.ext Anyone have any ideas for other test cases? (In reply to comment #4) > Thanks for the patch. > > Please follow the coding style guideline in the HACKING file : space before > method parenthesis, method names... > > Some unit tests would also be nice, to make sure there are no regressions. >
SafeUri was moved to Hyena, is there any update on this?
Hyena is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived: https://gitlab.gnome.org/Archive/hyena/commits/master Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.