After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556716 - Add themes documentation as DocBook.
Add themes documentation as DocBook.
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2008-10-17 12:08 UTC by Murray Cumming
Modified: 2008-10-18 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
/metacity_add_themes_docbook.patch (22.76 KB, patch)
2008-10-17 12:08 UTC, Murray Cumming
reviewed Details | Review
metacity_add_themes_docbook2.patch (23.56 KB, patch)
2008-10-17 14:12 UTC, Murray Cumming
committed Details | Review

Description Murray Cumming 2008-10-17 12:08:19 UTC
Here is a patch, as requested:

2008-10-17  Murray Cumming  <murrayc@murrayc.com>

	* configure.in: Call GNOME_DOC_INIT() so we can use the gnome-doc-utils 
	variables in our Makefile.am:
	* doc/Makefile.am:
	* doc/creating_themes/Makefile.am
	* doc/creating_themes/C/creating_metacity_themes.xml:
	Added this new DocBook document, converted from the HTML here
	http://blogs.gnome.org/metacity/2008/05/30/themes/
	This will be installed for yelp and can be translated and hosted on 
	library.gnome.org.
Comment 1 Murray Cumming 2008-10-17 12:08:55 UTC
Created attachment 120779 [details] [review]
/metacity_add_themes_docbook.patch
Comment 2 Thomas Thurman 2008-10-17 13:57:22 UTC
Thank you!  That was a very fast turnaround, and I really appreciate it.

Two possible problems, one very minor:

1) The conversion process has changed <!-- ... --> into <![dash] ... [dash]>; of course it's literally a double hyphen, not any kind of dash.  I can fix this, though.

2) More serious:  It doesn't build if this patch is applied, because you refer to doc/creating_themes/Makefile but don't supply a Makefile.am in that directory.  I'm not sure what a Makefile.am for a directory containing docbook ought to look like.  Can you show me or provide an example?
Comment 3 Murray Cumming 2008-10-17 14:12:51 UTC
Created attachment 120785 [details] [review]
metacity_add_themes_docbook2.patch

Sorry, I forgot to do an svn add for that file. Here is the patch again. I have left the dashes for you to fix.
Comment 4 Thomas Thurman 2008-10-18 01:55:57 UTC
Thanks-- added.  It doesn't like being run through docbook2html, though-- should it?  (It complains about "link url=..." among other things.)

Marking FIXED, anyway.
Comment 5 Thomas Thurman 2008-10-18 01:57:19 UTC
(I made a couple of tweaks, including changing the variable names to <varname> instead of <emphasis>; if this isn't okay I'll put it back)
Comment 6 Murray Cumming 2008-10-18 08:22:46 UTC
Sounds good.

I'll fix those link tags directly if that's OK. 
Comment 7 Thomas Thurman 2008-10-18 12:10:04 UTC
Sure, please do.  (There were a few other things it complained about as well; just run docbook2html over it to find them.)