After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556623 - correct spacings in glade dialogues
correct spacings in glade dialogues
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2008-10-16 19:38 UTC by Christian Persch
Modified: 2008-10-17 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (15.13 KB, patch)
2008-10-16 19:38 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2008-10-16 19:38:06 UTC 
The dialogue's borders were slightly wrong (6 instead of 5 for the dialogue and the main vbox's child, which adds up with the correct 2 (or 14 for alerts) of main vbox spacing to the required 12 (resp. 24) px). And some label: widget pairs had 6px instead of the required 12px spacing.

Attached patch corrects these.
Comment 1 Christian Persch 2008-10-16 19:38:19 UTC 
Created attachment 120750 [details] [review]
patch
Comment 2 Paolo Bacchilega 2008-10-17 07:05:52 UTC 
the HIG says the border width should be 6px, link here: http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-spacing
Comment 3 Christian Persch 2008-10-17 11:02:34 UTC 
Well, the HIG is wrong here.

We have

[1] GtkDialog
[2]  - internal vbox
[3]    - first child

Now suppose we set the border of [1] and [3] to 6px; take a screenshot and do some pixel counting. We find that the border is 14px instead of the required 12px. If we set the borders to 5px, it works out to 12px. (And these are the settings that are therefore used in every other Gnome module too.)
Comment 4 Paolo Bacchilega 2008-10-17 16:23:59 UTC 
ok, patch applied to trunk now, thanks.