After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556564 - [flvmux] Copy&paste bugs resulting in invalid files
[flvmux] Copy&paste bugs resulting in invalid files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-16 15:12 UTC by Sebastian Dröge (slomo)
Modified: 2008-10-16 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flvdemux.diff (1.41 KB, patch)
2008-10-16 15:14 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-10-16 15:12:32 UTC 
Hi,
flvmux currently sets video_codec instead of audio_codec in several places, resulting in invalid files when muxing some audio codecs.

attached patch fixes this and is obviously correct ;)
Comment 1 Sebastian Dröge (slomo) 2008-10-16 15:14:13 UTC 
Created attachment 120720 [details] [review]
flvdemux.diff
Comment 2 Sebastian Dröge (slomo) 2008-10-16 15:21:11 UTC 
2008-10-16  Sebastian Dröge  <slomo@circular-chaos.org>

	* gst/flv/gstflvmux.c: (gst_flv_mux_audio_pad_setcaps),
	(gst_flv_mux_write_buffer):
	Don't set video_codec to the value that actually should go
	into audio codec, otherwise we create invalid files.
	Fixes bug #556564.