After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556439 - improve logout/shutdown dialog messages
improve logout/shutdown dialog messages
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-15 17:20 UTC by Matthias Clasen
Modified: 2009-02-11 20:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (5.56 KB, patch)
2008-10-15 17:22 UTC, Matthias Clasen 		rejected Details | Review
fixed patch (6.82 KB, patch)
2009-01-12 06:11 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2008-10-15 17:20:55 UTC 
By not showing the 'logged in as' part when you are not actually logged in.

This is a string change, thus only suitable for trunk, I guess.
Comment 1 Matthias Clasen 2008-10-15 17:22:27 UTC 
Created attachment 120664 [details] [review]
patch
Comment 2 Matthias Clasen 2008-10-15 19:02:14 UTC 
While we are at it, we should probably remove the 'logged in as' part from the shutdown dialog altogether, and instead add some useful information, such as
'5 users are currently using this machine.'
Comment 3 Lucas Rocha 2009-01-09 01:20:12 UTC 
Matthias, the patch is missing the actual implementation of gsm_consolekit_get_current_session_type().
Comment 4 Lucas Rocha 2009-01-09 01:21:49 UTC 
(In reply to comment #0)
> By not showing the 'logged in as' part when you are not actually logged in.

Just to know if got it right: this patch is an improvement for the case when gnome-session is being used by new gdm, right?
Comment 5 Matthias Clasen 2009-01-09 02:19:29 UTC 
Yes. Not showing 'logged in as' is meant for the login session. Showing 'n users are  currently using this machine' is meant for multiple concurrent sessions (ie fast user switching)
Comment 6 Matthias Clasen 2009-01-12 06:11:18 UTC 
Created attachment 126252 [details] [review]
fixed patch

Grr, I hate redoing work that was lost because I was too stupid to create a complete diff...
Comment 7 Matthias Clasen 2009-02-11 17:10:54 UTC 
Lucas, any chance to get this in ?
Comment 8 Lucas Rocha 2009-02-11 20:20:53 UTC 
Commited in trunk. I files a separate bug for what was suggested in comment #2 (bug #571345).