After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556428 - [mpegpsdemux] Creates invalid newsegment events
[mpegpsdemux] Creates invalid newsegment events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-15 15:58 UTC by Edward Hervey
Modified: 2008-10-16 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.06 KB, patch)
2008-10-15 16:00 UTC, Edward Hervey 		none Details | Review
smaller patch (1.07 KB, patch)
2008-10-15 17:51 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2008-10-15 15:58:50 UTC 
The new mpegpsdemux element doesn't do any checks of the values it uses for new_segment events.
Comment 1 Edward Hervey 2008-10-15 16:00:40 UTC 
Created attachment 120654 [details] [review]
Proposed fix
Comment 2 Sebastian Dröge (slomo) 2008-10-15 16:08:27 UTC 
Looks good but the way you're doing it now you can leave the part where "time" is set as is... because "start" simply always has a valid value ;)
Comment 3 Edward Hervey 2008-10-15 17:51:45 UTC 
Created attachment 120669 [details] [review]
smaller patch

Indeed, that check isn't needed :)
Comment 4 Edward Hervey 2008-10-16 09:19:34 UTC 
2008-10-16  Edward Hervey  <edward.hervey@collabora.co.uk>

        * gst/mpegdemux/gstmpegdemux.c: (gst_flups_demux_send_data):
        Make sure the mpegpsdemux element creates valid newsegment events.
        Fixes #556428