After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556381 - [icydemux] test fails with latest core
[icydemux] test fails with latest core
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-15 08:57 UTC by Edward Hervey
Modified: 2008-10-15 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Take into account the extra references if building against latest core (1.25 KB, patch)
2008-10-15 09:02 UTC, Edward Hervey 		none Details | Review
Just don't check the refcount (645 bytes, patch)
2008-10-15 09:16 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2008-10-15 08:57:32 UTC 
the gst-plugins-good/tests/check/elements/icydemux.c test fails with latest core.

This is due to the fact that, when linking two pads, two GstStructureChangeMessage's are being emitted (one just before, and one just after), both taking a reference on the pad.

The test needs to be modified accordingly if testing against a 0.10.21 (or above) core.
Comment 1 Edward Hervey 2008-10-15 09:02:49 UTC 
Created attachment 120627 [details] [review]
Take into account the extra references if building against latest core

This patch takes into account the 2 extra references taken on the pad when building against latest core.
Comment 2 Tim-Philipp Müller 2008-10-15 09:04:30 UTC 
Or maybe we should just remove the refcount check entirely here?
Comment 3 Edward Hervey 2008-10-15 09:16:15 UTC 
Created attachment 120628 [details] [review]
Just don't check the refcount

After discussing with Tim and Jan about this one, this refcount check seems useless.
Comment 4 Jan Schmidt 2008-10-15 09:18:48 UTC 
bon! Commit quoi!
Comment 5 Edward Hervey 2008-10-15 09:28:33 UTC 
2008-10-15  Edward Hervey  <edward.hervey@collabora.co.uk>

	* gst/qtdemux/qtdemux.c: (qtdemux_parse_node):
	Remove problematic and useless refcount check.
	Fixes #556381
Comment 6 Edward Hervey 2008-10-15 09:39:43 UTC 
2008-10-15  Edward Hervey  <edward.hervey@collabora.co.uk>

	* gst/qtdemux/qtdemux.c: Remove previous wrong commit
	* tests/check/elements/icydemux.c: (icydemux_found_pad):
	Remove problematic and useless refcount check.
	Fixes #556381