After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556336 - [PATCH] gstffmpegdec.c: prefer demuxer's pixel aspect ratio over the decoder's
[PATCH] gstffmpegdec.c: prefer demuxer's pixel aspect ratio over the decoder's
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-14 21:23 UTC by Robin Stocker
Modified: 2008-10-15 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
prefer demuxer's PAR over decoder's in gstffmpegdec.c (996 bytes, patch)
2008-10-14 21:25 UTC, Robin Stocker
committed Details | Review

Description Robin Stocker 2008-10-14 21:23:16 UTC
When both the demuxer and the decoder provide a non-1:1 PAR, currently the decoder is preferred. This patch changes it so that the demuxer is preferred, because that allows a user to control the PAR with the container (changing the PAR in the video stream is much more difficult). See also bug 555699 for the same problem with theoradec.

The current code does some "guessing" in that when both specify a PAR, the one with the non-square PAR is preferred. This means it doesn't respect a square PAR that is set in the container, but I don't know how important that is. Maybe that code should be changed to always prefer the demuxer's PAR, that would be more in line with the behaviour that is now implemented in theoradec and mpeg2dec (see bug 555699).
Comment 1 Robin Stocker 2008-10-14 21:25:02 UTC
Created attachment 120605 [details] [review]
prefer demuxer's PAR over decoder's in gstffmpegdec.c
Comment 2 Sebastian Dröge (slomo) 2008-10-15 11:27:45 UTC
2008-10-15  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Robin Stocker <robin at nibor dot org>

	* ext/ffmpeg/gstffmpegdec.c:
	(gst_ffmpegdec_add_pixel_aspect_ratio):
	If both, the decoder and the demuxer, provide a non-1:1 PAR
	prefer the one of the demuxer instead of the one of the decoder.
	Fixes bug #556336.