After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556184 - [PATCH] mpeg2dec: prefer container's pixel aspect ratio over the stream's
[PATCH] mpeg2dec: prefer container's pixel aspect ratio over the stream's
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-13 20:08 UTC by Robin Stocker
Modified: 2008-10-14 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prefer container's PAR over stream's in gstmpeg2dec.c (2.83 KB, patch)
2008-10-13 20:09 UTC, Robin Stocker 		committed Details | Review

Description Robin Stocker 2008-10-13 20:08:31 UTC 
When an MPEG 2 video stream is inside a container that specifies a custom pixel-aspect-ratio for it (e.g. in MKV), the PAR is currently ignored. See also bug 555699 for the same problem with theoradec:

http://bugzilla.gnome.org/show_bug.cgi?id=555699

With the following patch (based on Wim Taymans' patch for theoradec), mpeg2dec uses the PAR of the container if it is set.
Comment 1 Robin Stocker 2008-10-13 20:09:59 UTC 
Created attachment 120528 [details] [review]
prefer container's PAR over stream's in gstmpeg2dec.c
Comment 2 Sebastian Dröge (slomo) 2008-10-14 12:51:50 UTC 
2008-10-14  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Robin Stocker <robin at nibor dot org>

	* ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_init),
	(handle_sequence), (gst_mpeg2dec_setcaps):
	* ext/mpeg2dec/gstmpeg2dec.h:
	Prefer the container's PAR over the stream's PAR if it's
	given in the srcpad caps. Fixes bug #556184.