After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556130 - bogus override of python includes in configure.ac
bogus override of python includes in configure.ac
Status: RESOLVED FIXED
Product: pygtk
Classification: Bindings
Component: general
Git Master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-13 13:08 UTC by Loïc Minier
Modified: 2009-01-28 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't override PYTHON_INCLUDES, it's already set by AM_CHECK_PYTHON_HEADERS (562 bytes, patch)
2008-10-13 13:15 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2008-10-13 13:08:46 UTC 
Hi,

PYTHON_INCLUDES="-I${py_prefix}/include/python${PYTHON_VERSION}"

is incorrect (doesn't honor $PYTHON-config as in m4/python.m4) and overwrites tje correct PYTHON_INCLUDES which is already set by AM_CHECK_PYTHON_HEADERS.

It breaks the build with python2.5-dbg in Ubuntu.

Will attach a patch to simply drop this line.

Bye,
Comment 1 Loïc Minier 2008-10-13 13:15:00 UTC 
Created attachment 120498 [details] [review]
Don't override PYTHON_INCLUDES, it's already set by AM_CHECK_PYTHON_HEADERS
Comment 2 Loïc Minier 2009-01-14 12:35:28 UTC 
Any objection to commit this if it still applies?
Comment 3 Gustavo Carneiro 2009-01-14 12:55:29 UTC 
No objections.
Comment 4 Gian Mario Tagliaretti 2009-01-28 00:14:58 UTC 
I committed this in both trunk and 2.14 branch (not yet released).

Thanks Loïc