After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556086 - Use gtk_show_uri instead of gnome_help
Use gtk_show_uri instead of gnome_help
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: GNOME2.26
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-13 03:22 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2008-11-26 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Drop gnome_help_display for gtk_show_uri from eog-util (726 bytes, patch)
2008-10-13 03:22 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2008-10-13 03:22:15 UTC 
Patch follows.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2008-10-13 03:22:56 UTC 
Created attachment 120485 [details] [review]
[PATCH] Drop gnome_help_display for gtk_show_uri from eog-util


Closes: bug #556086.
---
 src/eog-util.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)
Comment 2 Claudio Saavedra 2008-10-13 08:01:11 UTC 
Nice. Please commit with a proper ChangeLog entry after we've branched for 2.24.
Comment 3 Claudio Saavedra 2008-10-13 08:02:31 UTC 
Also, bumping the GTK+ dependency version may be necessary.
Comment 4 Felix Riemann 2008-10-13 20:35:36 UTC 
I took care of the dependency.

2008-10-13  Felix Riemann  <>

	* configure.ac: this requires at least GTK+-2.13.1
	* src/eog-util.c: (eog_util_show_help):
	Use gtk_show_uri instead of gnome-help to launch the help.
	Fixes bug #556086 (Diego Escalante Urrelo).
-------------------------------------------------------------------------------
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2008-10-13 21:56:18 UTC 
Perhaps we should use gtk_get_current_event_time ()? Note that it gives GDK_CURRENT_TIME by default, but I'm wondering if it's safer to use the gtk_* function...
Comment 6 Felix Riemann 2008-10-14 09:47:06 UTC 
Yes, you're right. :)
I didn't remember that we can get Key/ButtonEvents in our show_help function. Thanks.

2008-10-14  Felix Riemann  <>

	* src/eog-util.c: (eog_util_show_help): 
	Use gtk_get_current_event_time() instead of GDK_CURRENT_TIME
	with gtk_show_uri (Diego Escalante Urrelo).
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2008-11-26 12:43:57 UTC 
Updating patch status.