After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556019 - Add the ability to make souphttpsrc act as a live source
Add the ability to make souphttpsrc act as a live source
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-12 14:23 UTC by Sjoerd Simons
Modified: 2009-01-23 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.52 KB, patch)
2008-10-12 14:24 UTC, Sjoerd Simons
committed Details | Review

Description Sjoerd Simons 2008-10-12 14:23:08 UTC
For certain http streams, for example multipart jpeg cameras, it's usefull to have the httpsrc timestamp the incoming buffers. Being derived from basesrc, souphttpsrc already has a do-timestamp property, but as it's not a live source, it will start pushing buffers before there is a clock selected. Hence the first few buffers have a wrong timestamp. 

Attached patch solves this by adding a property to turn the souphttpsrc into a live src. In combination with do-timestamp this makes it push out nicely timestamped buffers
Comment 1 Sjoerd Simons 2008-10-12 14:24:44 UTC
Created attachment 120439 [details] [review]
proposed patch
Comment 2 Sebastian Dröge (slomo) 2008-10-13 09:14:30 UTC
Looks good, I'll commit it after freeze :)
Comment 3 Sebastian Dröge (slomo) 2008-10-27 09:00:37 UTC
2008-10-27  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	Patch by: Sjoerd Simons <sjoerd at luon dot net>

	* ext/soup/gstsouphttpsrc.c: (gst_soup_http_src_class_init),
	(gst_soup_http_src_set_property), (gst_soup_http_src_get_property):
	Add support for souphttpsrc to act as a live source. This makes it
	possible to get timestamped buffers in combination with the
	"do-timestamp" property. Fixes bug #556019.
Comment 4 rmcouat 2008-11-18 21:35:29 UTC
I see this is closed already but I need the same thing on gnomevfssrc. Would it not be better to just add this to GstBaseSrc where the property instance variable is located? This would add the capability to any derived class that needs it much the same way do-timestamp is implemented. I use gnomevfssrc for mjpeg cameras because it allows basic authentication in the location parameter which souphttpsrc does not.
Comment 5 rmcouat 2008-11-27 16:59:06 UTC
Addressed my issue in 561775 so no need on gnomevfssrc.