After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556003 - [flvdemux] Regression in handling flow returns in pull-mode
[flvdemux] Regression in handling flow returns in pull-mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-12 11:06 UTC by Sebastian Dröge (slomo)
Modified: 2008-10-12 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
diff (1.68 KB, patch)
2008-10-12 11:08 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-10-12 11:06:39 UTC 
Hi,
flvdemux in latest CVS has a regression in handling flow returns in pull-mode. When pulling from upstream fails for some reason the flow return is dropped and handled like GST_FLOW_OK due to a small mistake while refactoring.

Attached patch fixes this.
Comment 1 Sebastian Dröge (slomo) 2008-10-12 11:08:25 UTC 
Created attachment 120428 [details] [review]
diff
Comment 2 Sebastian Dröge (slomo) 2008-10-12 17:08:02 UTC 
2008-10-12  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	* gst/flv/gstflvdemux.c: (gst_flv_demux_pull_tag),
	(gst_flv_demux_pull_header):
	Fix regression of handling flow returns in pull mode.
	Fixes bug #556003.