After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 555700 - Documentation: GstXml says to "override" functions, not vfuncs.
Documentation: GstXml says to "override" functions, not vfuncs.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-09 16:33 UTC by Murray Cumming
Modified: 2008-10-10 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Murray Cumming 2008-10-09 16:33:28 UTC 
The GstXml documentation
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstXML.html
says 
"GstElement implementations need to override gst_object_save_thyself() and gst_object_restore_thyself()."

This should specifically recommend overiding the save_thyself() and restore_thyself() virtual functions (pointers to functions in GstObjectClass), to avoid confusion.

By the way "thyself" is a stupid word to use in API.
Comment 1 Sebastian Dröge (slomo) 2008-10-10 15:37:53 UTC 
2008-10-10  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	* gst/gstxml.c:
	Clarify that the save_thyself() and restore_thyself() virtual
	functions of GstObject need to be overriden, not
	gst_object_(save|restore)_thyself() which is impossible.
	Fixes bug #555700.