After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554937 - Seahorse-viewer.c is excluded from translation
Seahorse-viewer.c is excluded from translation
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal critical
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2008-10-03 23:42 UTC by Nickolay V. Shmyrev
Modified: 2008-10-11 21:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nickolay V. Shmyrev 2008-10-03 23:42:57 UTC 
For no reason it's placed in POTFILES.skip. Not almost all UI is not translated properly.
Comment 1 Adam Schreiber 2008-10-03 23:44:39 UTC 
seahorse-viewer.c is a valac generated file, seahorse-viewer.vala should probably be in the list though or however vala handles translations.
Comment 2 Nickolay V. Shmyrev 2008-10-03 23:47:58 UTC 
There is no seahorse-viewer.vala in trunk.

Another point, vala is bad for translations for the reason that 

#include <config.h>

is placed after

#include <glib/gi18n.h>

so basically preprocessor will not know about ENABLE_NLS at all.
Comment 3 Nickolay V. Shmyrev 2008-10-09 08:20:58 UTC 
Any news on this critical issue?
Comment 4 Adam Schreiber 2008-10-10 18:20:40 UTC 
I'll look at it tomorrow.  I've been fighting a paper submission deadline.
Comment 5 Adam Schreiber 2008-10-11 20:07:05 UTC 
2008-10-11  Adam Schreiber  <sadam@clemson.edu>

    * po/POTFILES.skip: Remove src/seahorse-viewer.c.  Fixes bug #554937
Comment 6 Gabor Kelemen 2008-10-11 20:10:51 UTC 
Umm... how about adding it to POTFILES.in? :)
Comment 7 Adam Schreiber 2008-10-11 21:11:20 UTC 
done.

2008-10-11  Adam Schreiber  <sadam@clemson.edu>

    * po/POTFILES.in: Add src/seahorse-viewer.c.